Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose realtimeDataFrom for refreshJourney #239

Closed
yu-re-ka opened this issue Aug 17, 2021 · 1 comment · Fixed by #240
Closed

Expose realtimeDataFrom for refreshJourney #239

yu-re-ka opened this issue Aug 17, 2021 · 1 comment · Fixed by #240
Labels
enhancement help wanted

Comments

@yu-re-ka
Copy link

journeys() returns a realtimeDataFrom, but refreshJourney() does not, even though the data is in the raw response
@derhuerst
Copy link
Member

PR welcome!

Let's just expose it as journey.realtimeDataFrom for now, and change refreshJourney()'s return value to an object {journey, realtimeDataFrom} with the next major release (#86).

yu-re-ka pushed a commit to yu-re-ka/hafas-client that referenced this issue Aug 17, 2021
@yuyuyureka
Expose realtimeDataFrom for refreshJourney
d8a36bc 
Fixes public-transport#239
@yu-re-ka yu-re-ka mentioned this issue Aug 17, 2021
Merged
derhuerst pushed a commit that referenced this issue Aug 17, 2021
@yuyuyureka @derhuerst
Expose realtimeDataFrom for refreshJourney
c10f318 
Fixes #239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose realtimeDataFrom for refreshJourney yu-re-ka/hafas-client
2 participants
@derhuerst @yu-re-ka