Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cw721-receiver contract #144

Merged
merged 13 commits into from
Feb 7, 2024

Conversation

chipshort
Copy link
Contributor

This implements an example contract that can receive a cw721 token and then just succeed or error depending on the passed message.

Also fine if you don't want to merge. We just needed this for a wasmd test. In that case, just close it.

@JakeHartnell
Copy link
Collaborator

This is really helpful! Have had to make similar contracts to this myself... maybe we need a test-contracts folder? Open to ideas from others but would be down to have some test contracts like this.

@shanev shanev requested review from shanev, larry0x and Art3miX December 29, 2023 20:31
@Art3miX
Copy link
Collaborator

Art3miX commented Dec 30, 2023

This is really helpful! Have had to make similar contracts to this myself... maybe we need a test-contracts folder? Open to ideas from others but would be down to have some test contracts like this.

I think having a test-contracts folder is smart, you almost always need a test contract if you work with cw721

Copy link
Collaborator

@Art3miX Art3miX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute little contract.

P.s, need CI fix.

contracts/cw721-receiver/Cargo.toml Outdated Show resolved Hide resolved
contracts/cw721-receiver/Cargo.toml Outdated Show resolved Hide resolved
contracts/cw721-receiver/tests/multitest.rs Outdated Show resolved Hide resolved
@chipshort
Copy link
Contributor Author

I applied @Art3miX's feedback.
Should I create a test-contracts folder and move it there?

Copy link
Collaborator

@Art3miX Art3miX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taitruong
Copy link
Collaborator

I applied @Art3miX's feedback. Should I create a test-contracts folder and move it there?

Just rename it to cw721-receiver-tester, no extra folder needed imo. Once done we can merge it then.

@chipshort
Copy link
Contributor Author

Can someone merge? I don't have write access here

Copy link
Collaborator

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! This will be really useful.

@JakeHartnell JakeHartnell merged commit e63a7bb into public-awesome:main Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants