Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make minter for instantiate msg optional #151

Closed
taitruong opened this issue Jan 10, 2024 · 0 comments
Closed

make minter for instantiate msg optional #151

taitruong opened this issue Jan 10, 2024 · 0 comments

Comments

@taitruong
Copy link
Collaborator

taitruong commented Jan 10, 2024 •
edited
Loading

Rather prefer having minter: Option<String>:
https://github.com/CosmWasm/cw-nfts/blob/177a993dfb5a1a3164be1baf274f43b1ca53da53/contracts/cw721-base/src/msg.rs#L8-L18

In case of none, info.sender should be minter. Makes it easier for other contracts (e.g. minter) re-using this msg.
taitruong added a commit to arkprotocol/cw-nfts that referenced this issue Jan 10, 2024
@taitruong
public-awesome#151 make minter optional
54eb891
@taitruong taitruong mentioned this issue Jan 10, 2024
Merged
shanev added a commit that referenced this issue Jan 19, 2024
@shanev
Merge pull request #152 from arkprotocol/optional_minter
378ae39 
#151 make minter optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taitruong