Added Jest test and tweaked babel config a bit to make it work #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related pubkey/rxdb#2596 |
pubkey
added a commit
that referenced
this pull request
Oct 20, 2020
|
@arielnmz I changed some code. Can you merge my change into the PR so we can se if this fixed the problem? |
|
Will do, sorry I got caught up in other stuff last week |
arielnmz
pushed a commit
to arielnmz/broadcast-channel
that referenced
this pull request
Oct 29, 2020
Also added eslint jest env so it doesn't complain about missing symbols
arielnmz
force-pushed
the
jest-test-never-ends
branch
from
be38815 to
510a2ee
Compare
…#348 Rebased test commit to include new code Also added eslint jest env so it doesn't complain about missing symbols
arielnmz
force-pushed
the
jest-test-never-ends
branch
from
510a2ee to
e0cb4e5
Compare
|
I just checked and it works now, thanks a lot! |
This was referenced Mar 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a very simple test in
close.test.jsthat exemplifies the issue. I don't know about mocha or Karma but Jest is what I'm using and that's where I have the issue. I added the jest package to dev dependencies and also tweaked the babel config a bit to make Jest work. If you run the test using the command line e.g.jest closeyou will get a warning stating thatSame if you run them using WebStorm's Jest test runner, for example.