Fix Detected a division by zero in Animated.divide node #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On first render width is 0 which is causing Detected a division by zero in Animated.divide node.
|
+1 this is a major issue |
syzer
reviewed
Oct 23, 2017
index.js
Outdated
| @@ -329,7 +329,7 @@ const ScrollableTabView = createReactClass({ | |||
| _handleLayout(e) { | |||
| const { width, } = e.nativeEvent.layout; | |||
|
|
|||
| if (Math.round(width) !== Math.round(this.state.containerWidth)) { | |||
| if (width > 0 && Math.round(width) !== Math.round(this.state.containerWidth)) { | |||
There was a problem hiding this comment.
Did you consider returning early ?
ex:
if (!width || Math.round(width) === Math.round(this.state.containerWidth) {
return
}
|
@syzer returning early now. |
|
@chaitanya0bhagvan Why did you delete the branch? It still does not work. |
|
@adamski This is already merged but a new version is not pushed to npm. |
|
Ok great, I'll use the git url instead, thanks |
anchengjian
pushed a commit
to anchengjian/react-native-scrollable-tab-view
that referenced
this pull request
Sep 29, 2018
Fix Detected a division by zero in Animated.divide node
caglaruba
pushed a commit
to caglaruba/react-native-scrollable-tab-view
that referenced
this pull request
Aug 22, 2019
Fix Detected a division by zero in Animated.divide node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first render width is 0 which is causing Detected a division by zero in Animated.divide node.