-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
egg(teamspeak): fix database support #4513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to contribute to the project. I'm afraid there are some breaking issues:
- This redirection breaks the tar step causing the whole installation to fail. You either want to use
&&
or perform the copy on a different line.
880379a
to
255b439
Compare
Sorry for the late response and the wrong pull request. I've updated the commit, and it should be working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing 👍
If you are able to can you rebase your changes on top of |
This fixes MariaDB-support for this egg by coping a required library to the correct location.
Should be correct and on top of |
I know pull requests from new contributors aren't usually allowed, but this is a very small change that gave me a headache the other day.
It fixes database support for MariaDB by copying a necessary library. See https://forum.teamspeak.com/threads/132925-unable-to-load-database-plugin-library-libts3db_mariadb-so