Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egg(teamspeak): fix database support #4513

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

Wunderharke
Copy link
Contributor

I know pull requests from new contributors aren't usually allowed, but this is a very small change that gave me a headache the other day.
It fixes database support for MariaDB by copying a necessary library. See https://forum.teamspeak.com/threads/132925-unable-to-load-database-plugin-library-libts3db_mariadb-so

@lancepioch lancepioch requested a review from parkervcp November 1, 2022 22:17
Copy link
Member

@trenutoo trenutoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute to the project. I'm afraid there are some breaking issues:

  • This redirection breaks the tar step causing the whole installation to fail. You either want to use && or perform the copy on a different line.

@Wunderharke Wunderharke force-pushed the patch-1 branch 2 times, most recently from 880379a to 255b439 Compare November 26, 2022 13:49
@Wunderharke
Copy link
Contributor Author

Sorry for the late response and the wrong pull request. I've updated the commit, and it should be working now.
I've moved the command to a new line and also escaped the slashes.

@Wunderharke Wunderharke requested review from trenutoo and removed request for parkervcp November 26, 2022 13:52
Copy link
Member

@trenutoo trenutoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing 👍

@matthewpi matthewpi changed the base branch from develop to 1.0-develop November 28, 2022 16:54
@matthewpi matthewpi changed the title Fix Teamspeak database support egg(teamspeak): fix database support Nov 28, 2022
@matthewpi
Copy link
Member

If you are able to can you rebase your changes on top of 1.0-develop? When I switched the branch the PR will merge into, the commits develop has ahead of 1.0-develop persisted.

This fixes MariaDB-support for this egg by coping a required library to the correct location.
@Wunderharke
Copy link
Contributor Author

Should be correct and on top of 1.0-develop now.

@matthewpi matthewpi merged commit c8f7bdf into pterodactyl:1.0-develop Nov 28, 2022
colecrouter pushed a commit to colecrouter/pterodactyl-panel that referenced this pull request Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Released
Development

Successfully merging this pull request may close these issues.

3 participants