Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support canceling individual uploads or all in-progress #4441

Merged
merged 5 commits into from
Nov 21, 2022

Conversation

DaneEveritt
Copy link
Member

closes #4440

Added the @preact/react-signals package so that I can begin using it elsewhere on the frontend as well. Significantly nicer to work with compared to normal hooks.

@tmunsch
Copy link

tmunsch commented Oct 24, 2022

I Implemented this and it seems to cancel the entire upload if you select an individual file upload to cancel.

@tmunsch
Copy link

tmunsch commented Oct 24, 2022

image
image

@matthewpi matthewpi changed the base branch from develop to 1.0-develop October 31, 2022 16:29
@matthewpi matthewpi merged commit df9a7f7 into 1.0-develop Nov 21, 2022
@matthewpi matthewpi deleted the dane/cancel-uploads branch November 21, 2022 20:59
@IllInuz
Copy link

IllInuz commented Dec 13, 2022

Seems to be resulting in an issue on 1.1.12
Cannot find module '@preact/signals-react' or its corresponding type declarations.
When running yarn build production.

When installed using --force params it worked (aside from some warnings),but it resulted in breaking the installation
https://i.imgur.com/vrwFjkM.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel Button for uploads
4 participants