We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint: /api/application/nodes/x
Object "description" are ignored on PATCH request
The endpoint must accept "description" update.
Solution: Add 'description', to /app/Http/Requests/Api/Application/Nodes/StoreNodeRequest.php
` public function rules(array $rules = null): array { return collect($rules ?? Node::getRules())->only([ 'public', 'name', 'description', 'location_id', 'fqdn', 'scheme', 'behind_proxy', 'memory', 'memory_overallocate', 'disk', 'disk_overallocate', 'upload_size', 'daemonListen', 'daemonSFTP', 'daemonBase', ])->mapWithKeys(function ($value, $key) { $key = ($key === 'daemonSFTP') ? 'daemonSftp' : $key;
return [snake_case($key) => $value]; })->toArray(); }
`
Make a PATCH request to /api/application/nodes/x
Description will not change
with:
{ "name": "NODETEST", "description": "TESTEXX", "location_id": 1, "fqdn": "nodetest.domain.com", "scheme": "https", "behind_proxy": false, "maintenance_mode": false, "memory": 6144, "memory_overallocate": -1, "disk": 750000, "disk_overallocate": -1, "upload_size": 100, "daemon_listen": 443, "daemon_sftp": 2022 }
1.6.0
1.5.0
No response
The text was updated successfully, but these errors were encountered:
api(application): allow updating node description
7d1cb29
fixes #3624
No branches or pull requests
Is there an existing issue for this?
Current Behavior
Endpoint: /api/application/nodes/x
Object "description" are ignored on PATCH request
Expected Behavior
The endpoint must accept "description" update.
Solution: Add 'description', to /app/Http/Requests/Api/Application/Nodes/StoreNodeRequest.php
` public function rules(array $rules = null): array
{
return collect($rules ?? Node::getRules())->only([
'public',
'name',
'description',
'location_id',
'fqdn',
'scheme',
'behind_proxy',
'memory',
'memory_overallocate',
'disk',
'disk_overallocate',
'upload_size',
'daemonListen',
'daemonSFTP',
'daemonBase',
])->mapWithKeys(function ($value, $key) {
$key = ($key === 'daemonSFTP') ? 'daemonSftp' : $key;
`
Steps to Reproduce
Make a PATCH request to /api/application/nodes/x
Description will not change
with:
Panel Version
1.6.0
Wings Version
1.5.0
Error Logs
No response
The text was updated successfully, but these errors were encountered: