Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file copy/move/delete REST endpoints to handle UNC paths better #521

Closed
mountaindude opened this issue Aug 6, 2022 · 0 comments · Fixed by #525, #526 or #529
Closed

Refactor file copy/move/delete REST endpoints to handle UNC paths better #521

mountaindude opened this issue Aug 6, 2022 · 0 comments · Fixed by #525, #526 or #529
Assignees
@mountaindude
Labels
enhancement
Milestone
8.4.0

Comments

@mountaindude
Copy link
Collaborator

mountaindude commented Aug 6, 2022 •
edited
Loading

UNC paths not handled well as of 8.3.3.
Can be made to work in some cases, but not very stable or intuitive.

Specifically:

  • More robust parsing of approved paths for file copy/move/delete operations.
  • More robust parsing of file/path provided in the call to the REST API endpoint.
@mountaindude mountaindude self-assigned this Aug 6, 2022
@mountaindude mountaindude added this to the 8.4.0 milestone Aug 6, 2022
mountaindude added a commit to mountaindude/butler that referenced this issue Aug 6, 2022
@mountaindude
feat: Make file copy/move/delete REST endpoints more robust
ca91a2b 
Implements ptarmiganlabs#521
mountaindude added a commit to mountaindude/butler that referenced this issue Aug 6, 2022
@mountaindude
Additional changes towards ptarmiganlabs#521
da16ac1
mountaindude added a commit to mountaindude/butler that referenced this issue Aug 6, 2022
@mountaindude
Update tests ert ptarmiganlabs#521
079a4ff
mountaindude added a commit to mountaindude/butler that referenced this issue Aug 6, 2022
@mountaindude
File path normalization towards ptarmiganlabs#521
bb71a6a
@github-actions github-actions bot mentioned this issue Aug 7, 2022
Merged
This was referenced Aug 7, 2022
Merged
Merged
@github-actions github-actions bot mentioned this issue Oct 3, 2022
Merged
@github-actions github-actions bot mentioned this issue May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mountaindude mountaindude

Labels
enhancement
Projects
None yet
Milestone
8.4.0
1 participant
@mountaindude