fix: Only send to New Relic if event/log is enabled AND custom proper…

…ty name specified. Fixes #596
ptarmiganlabs · Dec 2, 2022 · 9fc81d0 · 9fc81d0
1 parent be6db37
commit 9fc81d0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/lib/incident_mgmt/new_relic.js b/src/lib/incident_mgmt/new_relic.js
@@ -578,7 +578,7 @@ async function sendReloadTaskFailureEvent(reloadParams) {
                 if (
                     globals.config.has(
                         'Butler.incidentTool.newRelic.reloadTaskFailure.destination.event.sendToAccount.byCustomProperty.enable'
-                    ) ||
+                    ) &&
                     globals.config.has(
                         'Butler.incidentTool.newRelic.reloadTaskFailure.destination.event.sendToAccount.byCustomProperty.customPropertyName'
                     )
@@ -706,7 +706,7 @@ async function sendReloadTaskFailureLog(reloadParams) {
                 if (
                     globals.config.has(
                         'Butler.incidentTool.newRelic.reloadTaskFailure.destination.log.sendToAccount.byCustomProperty.enable'
-                    ) ||
+                    ) &&
                     globals.config.has(
                         'Butler.incidentTool.newRelic.reloadTaskFailure.destination.log.sendToAccount.byCustomProperty.customPropertyName'
                     )
@@ -836,7 +836,7 @@ function sendReloadTaskAbortedEvent(reloadParams) {
                 if (
                     globals.config.has(
                         'Butler.incidentTool.newRelic.reloadTaskAborted.destination.event.sendToAccount.byCustomProperty.enable'
-                    ) ||
+                    ) &&
                     globals.config.has(
                         'Butler.incidentTool.newRelic.reloadTaskAborted.destination.event.sendToAccount.byCustomProperty.customPropertyName'
                     )
@@ -966,7 +966,7 @@ function sendReloadTaskAbortedLog(reloadParams) {
                 if (
                     globals.config.has(
                         'Butler.incidentTool.newRelic.reloadTaskAborted.destination.log.sendToAccount.byCustomProperty.enable'
-                    ) ||
+                    ) &&
                     globals.config.has(
                         'Butler.incidentTool.newRelic.reloadTaskAborted.destination.log.sendToAccount.byCustomProperty.customPropertyName'
                     )