fix: No more errors when empty New Relic metrics attribute/header arr…

…ays in config file Fixes #467
ptarmiganlabs · May 20, 2022 · 81e65ca · 81e65ca
1 parent 3b34c49
commit 81e65ca
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/src/routes/newrelic_metric.js b/src/routes/newrelic_metric.js
@@ -22,9 +22,11 @@ async function handlerPostNewRelicMetric(request, reply) {
         if (globals.config.has('Butler.restServerEndpointsConfig.newRelic.postNewRelicMetric.attribute.static')) {
             const staticAttributes = globals.config.get('Butler.restServerEndpointsConfig.newRelic.postNewRelicMetric.attribute.static');
 
-            // eslint-disable-next-line no-restricted-syntax
-            for (const item of staticAttributes) {
-                attributes[item.name] = item.value;
+            if (staticAttributes !== null && staticAttributes.length > 0) {
+                // eslint-disable-next-line no-restricted-syntax
+                for (const item of staticAttributes) {
+                    attributes[item.name] = item.value;
+                }
             }
         }
 
@@ -70,9 +72,11 @@ async function handlerPostNewRelicMetric(request, reply) {
             'Api-Key': globals.config.get('Butler.thirdPartyToolsCredentials.newRelic.insertApiKey'),
         };
 
-        // eslint-disable-next-line no-restricted-syntax
-        for (const header of globals.config.get('Butler.restServerEndpointsConfig.newRelic.postNewRelicMetric.header')) {
-            headers[header.name] = header.value;
+        if (globals.config.get('Butler.restServerEndpointsConfig.newRelic.postNewRelicMetric.header') !== null) {
+            // eslint-disable-next-line no-restricted-syntax
+            for (const header of globals.config.get('Butler.restServerEndpointsConfig.newRelic.postNewRelicMetric.header')) {
+                headers[header.name] = header.value;
+            }
         }
 
         const res = await axios.post(remoteUrl, payload, { headers, timeout: 5000 });