fix(winservice): Better handling of services that don't exist

or cannot be reached. Fixers #864
ptarmiganlabs · Dec 6, 2023 · 56a18de · 56a18de
1 parent 6299a2c
commit 56a18de
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 7 deletions.
diff --git a/src/lib/service_monitor.js b/src/lib/service_monitor.js
@@ -119,9 +119,11 @@ const serviceMonitorMqttSend2 = (config, logger, svc) => {
 };
 
 const verifyServicesExist = async (config, logger) => {
+    logger.info('Verifying that all Windows services specified in config file exist and can be reached.');
+
     // Return false if one or more services do not exist or cannot be reached.
     // Return true if all services are reachable.
-    let result = false;
+    let result = true;
 
     const hostsToCheck = config.get('Butler.serviceMonitor.monitor');
 
@@ -132,13 +134,25 @@ const verifyServicesExist = async (config, logger) => {
 
         // eslint-disable-next-line no-restricted-syntax
         for (const service of servicesToCheck) {
-            // eslint-disable-next-line no-await-in-loop
-            const serviceExists = await svcTools.exists(service.name, host.host);
-            if (serviceExists) {
-                result = true;
+            let serviceExists;
+            try {
+                // eslint-disable-next-line no-await-in-loop
+                serviceExists = await svcTools.exists(service.name, host.host);
+            } catch (err) {
+                logger.error(`Error verifying existence and reachability of service ${service.name} on host ${host.host}: ${err}`);
+                result = false;
             }
 
-            logger.verbose(`Windows service ${service.name} (="${service.friendlyName}") on host ${host.host} exists: ${serviceExists}`);
+            if (serviceExists) {
+                logger.verbose(
+                    `Windows service ${service.name} (="${service.friendlyName}") on host ${host.host} exists: ${serviceExists}`
+                );
+            } else {
+                logger.error(
+                    `Windows service ${service.name} (="${service.friendlyName}") on host ${host.host} does not exist or cannot be reached.`
+                );
+                result = false;
+            }
         }
     }
 
@@ -539,7 +553,7 @@ async function setupServiceMonitorTimer(config, logger) {
                     }
                 } else {
                     logger.error(
-                        'At least one Windows service does not exist or could not be reached. Will not check any Windows services from here on.'
+                        'At least one Windows service does not exist or could not be reached. Monitoring of Windows services is disabled.'
                     );
                 }
             } else {

diff --git a/src/lib/winsvc.js b/src/lib/winsvc.js
@@ -10,6 +10,7 @@ function all(host = null) {
     // Create promise
     return new Promise((resolve, reject) => {
         let command = '';
+
         if (host === null) {
             // Run command for get states of all services on local machine
             command = 'sc.exe query state= all';
@@ -21,6 +22,9 @@ function all(host = null) {
         exec(command, (err, stdout) => {
             // On error, reject and exit
             if (err) {
+                if (stdout) {
+                    reject(stdout);
+                }
                 reject(err);
                 return;
             }
@@ -55,6 +59,8 @@ function exists(serviceName, host = null) {
             return;
         }
 
+        // Is host reachable?
+
         // Get all services
         all(host).then(
             // On success, check