Merge pull request #543 from mountaindude/526

526
ptarmiganlabs · Apr 24, 2024 · 26b8bd8 · 26b8bd8
2 parents 566f468 + 8c3266b
commit 26b8bd8
Show file tree

Hide file tree

Showing 5 changed files with 48 additions and 44 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -367,7 +367,7 @@ jobs:
         run: |
           pwd
           cd src
-          ./node_modules/.bin/esbuild ${DIST_FILE_NAME}.js  --bundle --external:vm2 --external:axios --outfile=build.cjs --format=cjs --platform=node --target=node18.5.0
+          ./node_modules/.bin/esbuild ${DIST_FILE_NAME}.js  --bundle --external:vm2 --external:axios --outfile=build.cjs --format=cjs --platform=node --target=node18
           pkg --output "../${DIST_FILE_NAME}" -t node18-macos-x64 ./build.cjs --config package.json --options no-deprecation --compress GZip
 
           cd ..
@@ -494,7 +494,7 @@ jobs:
       - name: Build binaries
         run: |
           cd src
-          ./node_modules/.bin/esbuild "${env:DIST_FILE_NAME}.js" --bundle --external:vm2 --external:axios --outfile=build.cjs --format=cjs --platform=node --target=node18.5.0
+          ./node_modules/.bin/esbuild "${env:DIST_FILE_NAME}.js" --bundle --external:vm2 --external:axios --outfile=build.cjs --format=cjs --platform=node --target=node18
           pkg --output "../${env:DIST_FILE_NAME}.exe" -t node18-win-x64 ./build.cjs --config package.json --options no-deprecation --compress GZip
 
           cd ..
@@ -589,7 +589,7 @@ jobs:
       - name: Build binaries
         run: |
           cd src
-          ./node_modules/.bin/esbuild ${DIST_FILE_NAME}.js  --bundle --external:vm2 --external:axios --outfile=build.cjs --format=cjs --platform=node --target=node18.5.0
+          ./node_modules/.bin/esbuild ${DIST_FILE_NAME}.js  --bundle --external:vm2 --external:axios --outfile=build.cjs --format=cjs --platform=node --target=node18
           pkg --output "../${DIST_FILE_NAME}" -t node18-linux-x64 ./build.cjs --config package.json --options no-deprecation --compress GZip
 
           cd ..

diff --git a/README.md b/README.md
@@ -1291,6 +1291,8 @@ First list installed browsers, then uninstall all of them. Finally list installe
 
 | Tested date | BSI version | Comment |
 |-------------|-------------|---------|
+| 2024-Apr-24 | 3.5.0 | Works without issues |
+| 2024-Apr-22 | 3.4.1 | Login page has changed, cannot log in |
 | 2024-Mar-8 | 3.4.1 | Works without issues |
 | 2024-Feb-16 | 3.2.3 | Works without issues |
 | 2023-Dec-6 | 3.2.0 | Works without issues |

diff --git a/src/lib/cloud/cloud-create-thumbnails.js b/src/lib/cloud/cloud-create-thumbnails.js
@@ -16,12 +16,10 @@ const QlikSaas = require('./cloud-repo');
 const { browserInstall } = require('../browser/browser-install.js');
 const { qscloudTestConnection } = require('./cloud-test-connection');
 
-const selectorLoginPageUserName =
-    '#lock-container > div > div > form > div > div > div:nth-child(3) > span > div > div > div > div > div > div > div > div > div > div.auth0-lock-input-block.auth0-lock-input-email > div.auth0-lock-input-wrap.auth0-lock-input-wrap-with-icon > input';
-const selectorLoginPageUserPwd =
-    '#lock-container > div > div > form > div > div > div:nth-child(3) > span > div > div > div > div > div > div > div > div > div > div.auth0-lock-input-block.auth0-lock-input-show-password > div > div.auth0-lock-input-wrap.auth0-lock-input-wrap-with-icon > input';
-const selectorLoginPageLoginButton =
-    '#lock-container > div > div > form > div > div > div.login-form--actions > button';
+// Selector paths to elements on login page
+const selectorLoginPageUserName = '[id="\u0031-email"]';
+const selectorLoginPageUserPwd = '[id="\u0031-password"]';
+const selectorLoginPageLoginButton = '[id="\u0031-submit"]';
 
 /**
  *
@@ -595,7 +593,11 @@ const qscloudCreateThumbnails = async (options) => {
                 logger.error(`TEST CONNECTIVITY 1 (stack): ${err.stack}`);
             } else if (err.message) {
                 logger.error(`TEST CONNECTIVITY 1 (message): ${err.message}`);
-                logger.error(`TEST CONNECTIVITY 1 (error code): ${err.status}="${err.statusText}"`);
+                if (err.status && err.statusText) {
+                    logger.error(
+                        `TEST CONNECTIVITY 1 (error code): ${err.status}="${err.statusText}"`
+                    );
+                }
             } else {
                 logger.error(`TEST CONNECTIVITY 1: ${err}`);
             }

diff --git a/src/package-lock.json b/src/package-lock.json
diff --git a/src/package.json b/src/package.json
@@ -18,7 +18,7 @@
     "screenshot"
   ],
   "dependencies": {
-    "@puppeteer/browsers": "^2.2.0",
+    "@puppeteer/browsers": "^2.2.2",
     "axios": "^1.6.8",
     "cli-progress": "^3.12.0",
     "commander": "^12.0.0",
@@ -32,18 +32,18 @@
     "form-data": "^4.0.0",
     "fs-extra": "^11.2.0",
     "os": "^0.1.2",
-    "puppeteer-core": "^22.6.0",
+    "puppeteer-core": "^22.7.0",
     "qrs-interact": "^6.3.1",
-    "table": "^6.8.1",
+    "table": "^6.8.2",
     "upath": "^2.0.1",
-    "winston": "^3.12.0",
+    "winston": "^3.13.0",
     "ws": "^8.16.0"
   },
   "devDependencies": {
     "@jest/globals": "^29.7.0",
     "jest": "^29.7.0",
     "prettier": "^3.2.5",
-    "snyk": "^1.1285.0"
+    "snyk": "^1.1290.0"
   },
   "repository": {
     "type": "git",