Improve error docs... and make some of the generated code a bit more readable #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uli Schlachter <[email protected]>
This commit adds a crate-internal trait that allows to shorten x.try_into().or(Err(ParseError::ConversionFailed)) to x.try_to_usize(). This also makes the code generator use this new trait/function. Thanks to this change, many of the affected expressions now actually fit into a single line on my screen! Signed-off-by: Uli Schlachter <[email protected]>
This commit deals with two / four special cases that were not dealt with in the previous commit yet. Signed-off-by: Uli Schlachter <[email protected]>
Signed-off-by: Uli Schlachter <[email protected]>
eduardosm
approved these changes
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while now I had "improve docs for
ParseError" on my to do list. I finally tackled this. For this, I looked at the generated code and checked when each of the errors could appear. I also found some types in the docs forConnectError. Thus, this is now a PR with four commits and only one of them is about what I actually wanted to do...