Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary From implementations #478

Closed
psychon opened this issue Jun 11, 2020 · 0 comments · Fixed by #581
Closed

Remove some unnecessary From implementations #478

psychon opened this issue Jun 11, 2020 · 0 comments · Fixed by #581
Labels
enhancement New feature or request good first issue Good for newcomers P5 Priority Nice-to-have

Comments

@psychon
Copy link
Owner

psychon commented Jun 11, 2020

#475 (comment)

I also think an easy followup to this would be dropping the From<&[u8]> and From<(&[u8], &mut Vec)> implementations for replies and replacing them with TryParse and TryParseFd respectively in the cookie code.

@psychon psychon added enhancement New feature or request good first issue Good for newcomers P5 Priority Nice-to-have labels Jun 11, 2020
psychon added a commit that referenced this issue Dec 31, 2020
Instead of requiring replies to implement TryFrom<&[u8],
Error=ParseError>, this commit changes the code to instead use the
TryParse trait that we have just for this purpose.

Related-to: #478
Signed-off-by: Uli Schlachter <[email protected]>
psychon added a commit that referenced this issue Dec 31, 2020
Related-to: #478
Signed-off-by: Uli Schlachter <[email protected]>
psychon added a commit that referenced this issue Dec 31, 2020
Related-to: #478
Signed-off-by: Uli Schlachter <[email protected]>
psychon added a commit that referenced this issue Dec 31, 2020
Related-to: #478
Signed-off-by: Uli Schlachter <[email protected]>
psychon added a commit that referenced this issue Dec 31, 2020
@mergify mergify bot closed this as completed in #581 Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P5 Priority Nice-to-have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant