Skip to content

Commit

Permalink
add couple TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
psviderski committed Sep 12, 2024
1 parent bd53e3f commit 3f497b5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions internal/cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ func (cli *CLI) ListMachines(ctx context.Context, clusterName string) error {
// Print the list of machines in a table format.
tw := tabwriter.NewWriter(os.Stdout, 0, 0, 3, ' ', 0)
// Print header.
// TODO: print ADDRESS instead of SUBNET which is a machine IP with prefix.
if _, err = fmt.Fprintln(tw, "NAME\tSUBNET\tPUBLIC KEY\tENDPOINTS"); err != nil {
return fmt.Errorf("write header: %w", err)
}
Expand Down
1 change: 1 addition & 0 deletions internal/machine/cluster/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ func (c *Cluster) AddMachine(ctx context.Context, req *pb.AddMachineRequest) (*p

// TODO: notify all cluster machines about the new machine so they can update their peers config.
// In PoC we just notify the local machine.
// TODO: there is a race condition with network configuration if a new cluster is initialized on the machine.
c.newMachinesCh <- m

resp := &pb.AddMachineResponse{Machine: m}
Expand Down

0 comments on commit 3f497b5

Please sign in to comment.