Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding draft works to collections #1256

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Allow adding draft works to collections #1256

merged 2 commits into from
Mar 2, 2022

Conversation

banukutlu
Copy link
Contributor

Closes #1231

@banukutlu banukutlu marked this pull request as draft February 24, 2022 23:53
@banukutlu banukutlu force-pushed the 1231-draft-works-to-collection branch 2 times, most recently from 852d1af to c79f0df Compare March 1, 2022 15:42
@banukutlu banukutlu marked this pull request as ready for review March 1, 2022 15:42
@banukutlu banukutlu requested review from nicktiberi and rschenk March 1, 2022 15:42
@banukutlu banukutlu changed the title allows to add draft work to collection, adds state badge Allow adding draft works to collections Mar 1, 2022
nicktiberi
nicktiberi reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@nicktiberi nicktiberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I did some local testing and noticed that if you have a collection with 1 draft work in it, and then publish the draft, the collection does not get reindexed, so the collection still won't appear in the main search results. I wonder if we need to just add an action to reindex any collections that the work is a part of as part of publishing a work version?

app/views/dashboard/form/members/_search.html.erb Outdated Show resolved Hide resolved
@banukutlu banukutlu force-pushed the 1231-draft-works-to-collection branch from c79f0df to 929bfed Compare March 1, 2022 16:07
@banukutlu
Copy link
Contributor Author

This looks great!

I did some local testing and noticed that if you have a collection with 1 draft work in it, and then publish the draft, the collection does not get reindexed, so the collection still won't appear in the main search results. I wonder if we need to just add an action to reindex any collections that the work is a part of as part of publishing a work version?

that makes sense, I will look into it. thanks for testing this.

@banukutlu banukutlu requested a review from nicktiberi March 1, 2022 21:00
@banukutlu banukutlu force-pushed the 1231-draft-works-to-collection branch from 432fd1b to 43bd9e6 Compare March 2, 2022 20:31
@banukutlu
Copy link
Contributor Author

@nicktiberi this is ready for review again :)

@nicktiberi
Copy link
Contributor

Awesome! I think this is good to go. Thanks, @banukutlu! 🙂 🚀

@banukutlu banukutlu merged commit 5c3ef6b into main Mar 2, 2022
@banukutlu banukutlu deleted the 1231-draft-works-to-collection branch March 2, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktiberi nicktiberi nicktiberi approved these changes

@rschenk rschenk Awaiting requested review from rschenk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to add draft works to a collection
2 participants
@banukutlu @nicktiberi