This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
Add additional checksum verification in specs #1389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
little9
force-pushed
the
external-files/additional-checksums-in-specs
branch
2 times, most recently
from
6a36a19 to
e686ba3
Compare
awead
approved these changes
Sep 6, 2018
little9
force-pushed
the
external-files/additional-checksums-in-specs
branch
2 times, most recently
from
20e2732 to
db04b57
Compare
This adds an additional checksum verification to the external files conversion spec. This ensures that the FixityService returns the sha1 we expect for the world.png file. It also ensures that the checksums are the same when the existing file is placed in `/tmp` and that the file that is downloaded from a redirect also has the correct checksum.
little9
force-pushed
the
external-files/additional-checksums-in-specs
branch
from
db04b57 to
f13ac1f
Compare
|
I'm going to close this because the other PR introduces the Checksummer class, which is tested and is used the conversion process. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional checksum verification to
the external files conversion spec. This ensures
that the FixityService returns the sha1 we expect
for the world.png file.
It also ensures that the checksums are the same
when the existing file is placed in
/tmpandthat the file that is downloaded from a redirect
also has the correct checksum.
Connected to #1301