Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "invalid number" errors (fix #40) #41

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix "invalid number" errors (fix #40) #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ticker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ for symbol in $(IFS=' '; echo "${SYMBOLS[*]}" | tr '[:lower:]' '[:upper:]'); do
preMarketChange="$(query $symbol 'preMarketChange')"
postMarketChange="$(query $symbol 'postMarketChange')"

if [ $marketState == "PRE" ] \
if [ $marketState = "PRE" ] \
&& [ $preMarketChange != "0" ] \
&& [ $preMarketChange != "null" ]; then
nonRegularMarketSign='*'
Expand All @@ -93,7 +93,11 @@ for symbol in $(IFS=' '; echo "${SYMBOLS[*]}" | tr '[:lower:]' '[:upper:]'); do
percent=$(query $symbol 'regularMarketChangePercent')
fi

if [ "$diff" == "0" ] || [ "$diff" == "0.0" ]; then
# see https://github.com/pstadler/ticker.sh/issues/40
[ "$diff" = "null" ] && diff="0.0"
[ "$percent" = "null" ] && percent="0.0"

if [ "$diff" = "0" ] || [ "$diff" = "0.0" ]; then
color=
elif ( echo "$diff" | grep -q ^- ); then
color=$COLOR_RED
Expand Down