public_inbox: Fix email threads without an available root message #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some type hints were set to return a given type, while the function was actually returning that type, or a None object. Fix the type hints when relevant. Signed-off-by: Maxime Ripard <[email protected]>
Some messages will not be perfect, and will have inconsistent or missing headers. We were mostly handling them fine, but didn't log anything when that was happening, making debugging issues fairly difficult. Let's improve the logging a bit. Signed-off-by: Maxime Ripard <[email protected]>
The PublicInbox.__fetch_thread_root method returns None implicitly at the end of the function. Let's use an explicit return statement to make it more obvious. Signed-off-by: Maxime Ripard <[email protected]>
A message can have an In-Reply-To header but the message it points to might not be available for some reason. In such a case, the Message.parent_id() method will return a proper value, but __fetch_thread_root() on that message might not and would return None. Let's handle that case by returning the latest message we found as the root message. Signed-off-by: Maxime Ripard <[email protected]>
|
Thanks! Tested with my setup and this PR fixes the issue! |
|
Hi, @mripard 😄. I'm afraid I haven't reported anything; don't even know this project 🤔. Wrong username, maybe? |
|
Yeah, sorry, I meant @martinezjavier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
@stefano-garzarella and @javierm have been reporting on the public-inbox plugin #329 that they were having crashes.
It turns out that lore doesn't always manage to archive all the messages and we might find emails with a valid in-reply-to header, but can't retrieve the message from the ML archive.
This was partly due to an improper type annotation, so this PR fixes both the type annotations and the actual bug they were both facing.