-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add first WIP for allowing to get stats about created releases #314
base: main
Are you sure you want to change the base?
Conversation
Hi @psss can you please give me same additional pointers where I need to modify the code so that it starts working? Thanks in advance! :) |
Signed-off-by: Simon L <[email protected]>
6764221
to
baeb398
Compare
Thanks for the draft! You just need to include the new stats in the Lines 244 to 266 in a3a49fa
Also make sure, that you correctly extract the list of projects from the Lines 235 to 239 in a3a49fa
Let me know if anything else is not clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice kick-off! Thanks! In order to make it work we need the Release
class though plus enabled the new stats under the GitHubStats
class.
@@ -9,6 +9,7 @@ | |||
url = https://api.github.com/ | |||
token = <authentication-token> | |||
login = <username> | |||
project = <project1, project2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project = <project1, project2> | |
project = <project1>, <project2> |
Let's make it a bit more clear that comma is a project separator here.
query = "repos/{0}/releases?q=author:{1}+created:{2}..{3}".format( | ||
project, self.user.login, self.options.since, self.options.until) | ||
self.stats = [ | ||
Releases(release) for release in self.parent.github.search(query)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is seems that you need to define the Release
class as well. It could be similar to the Issue
class above.
Close #310