Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarterly reports for calendar quarter #223

Closed
brakogh opened this issue May 5, 2020 · 5 comments
Closed

Quarterly reports for calendar quarter #223

brakogh opened this issue May 5, 2020 · 5 comments

Comments

@brakogh
Copy link

brakogh commented May 5, 2020

When using quarter for time range (did last quarter), did is currently using Financial Year (FY) quarters (March -> May), that doesn't match calendar year (CY) quarters (April -> Jun).
Please change did to use CY quarters instead of FY ones.

@psss
Copy link
Owner

psss commented May 5, 2020

We should make it configurable where the first quarter starts.

@brakogh
Copy link
Author

brakogh commented Jun 22, 2020

Any progress here? We already really need this feature for reporting.

psss added a commit that referenced this issue Jun 22, 2020
@psss
Copy link
Owner

psss commented Jun 22, 2020

Unfortunately nobody found time to make this configurable. I've created a simple pull request #224 which changes the default quarter alignment from fiscal year to calendar year. We can possibly leave the config feature for the future...

@hegerj
Copy link

hegerj commented Jun 23, 2020

@psss Is there a reason to make configurable at all? It seems to me most people would want to use CY quarters.

psss added a commit that referenced this issue Jul 9, 2020
Plus make the first month of the quarter configurable.
@psss psss closed this as completed in 59b8e91 Jul 9, 2020
@psss
Copy link
Owner

psss commented Jul 9, 2020

@psss Is there a reason to make configurable at all? It seems to me most people would want to use CY quarters.

If possible I always try to prevent any backward-incompatible changes. And if it's not possible I think it's good to at least provide a way how to enable the previous behaviour. In this case it really seems the default should be changed to the first month as majority of current users switched to the calendar year quarters. Change merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants