Fix for issue with justl-pop-to-buffer-on-display #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running 'justl' while `justl-pop-to-buffer-on-display` was set to nil, a blank buffer would be displayed. This was caused by a misunderstanding of the purpose of `justl--pop-to-buffer`; the new option is only intended to apply to compilation/output buffers, rather than interaction buffers, and `justl--pop-to-buffer` is only used for interaction buffers. The fix is to simply revert the behaviour of `justl--pop-to-buffer`, so it is unaffected by the new option. Also updated the option description and the changelog to be more explicit about which buffers the option is for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
When running 'justl' while
justl-pop-to-buffer-on-displaywas set to nil, a blank buffer would be displayed.This was caused by a misunderstanding of the purpose of
justl--pop-to-buffer; the new option is only intended to apply to compilation/output buffers, rather than interaction buffers, andjustl--pop-to-bufferis only used for interaction buffers.The fix is to simply revert the behaviour of
justl--pop-to-buffer, so it is unaffected by the new option.Also updated the option description and the changelog to be more explicit about which buffers the option is for.