Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option justl-pop-to-buffer-on-display #68

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

bbbscarter
Copy link
Contributor

Resolves issue #67

The current behaviour is that the justl buffer is selected when a command is run. This adds the option to make that behaviour optional, so it can display the buffer without selecting it.

The current behaviour is that the justl buffer is selected when a command is run. This option makes that behaviour optional, and displays the buffer without selecting it.
(defcustom justl-pop-to-buffer-on-display t
"If non-nil, selects the justl buffer when it is displayed.
If nil, displays the buffer without selecting it."
:type 'boolean
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add :group here ? You can see other defcustom for an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Yes, of course.

Copy link
Owner

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM apart from a minor comment. Can you also update the changelog ?

@bbbscarter
Copy link
Contributor Author

Thanks! Both of these are done now.

@psibi psibi closed this Nov 23, 2024
@psibi psibi reopened this Nov 23, 2024
@psibi psibi merged commit e04f656 into psibi:master Nov 23, 2024
5 checks passed
@psibi
Copy link
Owner

psibi commented Nov 23, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants