-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for executing recipes in vterm #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about introducing a new defcustom
instead ? Something like justl-default-shell
with two choices: eshell
and vterm
. eshell
can be the default.
The advantage that is that there is no need to introduce new keybinding. Based on the option configured, you use the existing keybinding.
I went ahead and changed it to use the Additionally, I'm wondering whether an obsolete alias should be added for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I liked your previous implementation even though it will likely add more code. Can you do the following:
- Define new function justl-exec-vterm and justl-no-exec-vterm similar to how you did before.
- Create new function justl-exec-shell and justl-no-exec-shell as you have defined in the latest commit. This function should call the apprpriate functions based on the justl-default-shell variable.
The main motivation is to make it easier to add support for other shells.
Done.
Done. I updated the default keybinds to use these functions.
I agree that this is a better approach to accomplish this goal. Let me know if there are any other changes you'd like me to make. |
Thank you! |
As proposed in #54.
I just went ahead and chose
v
andV
as the keybinds since they made sense to me, but I'm open to changing it if desired. RIght now the keys are always bound and thenvterm
's presence is checked when the commands are called (viarequire
); I'm not sure if this is the best way to support this as an "optional" feature, so I'm open to feedback on that as well.