Fix just executable argument positioning when setting custom flags #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the justl parsing and exec functions so that arguments are ordered correctly when calling just: arguments which are destined for just the executable should be defined before the recipe, since the recipe can have its own arguments.
|
Umm, when I run ERT locally it passes - is there something wrong with CI?
|
Don't think so, since it passes in master branch: https://github.com/psibi/justl.el/actions/runs/5921611832/job/16054384296 |
|
Ok, maybe my Emacs' state was incorrect, I Will have a look tomorrow evening if I get a chance! |
Closed
If the user sets the --unstable flag in Transient, the args list would have --unstable twice, which causes just to throw an error. Instead, deduplicate the list.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
justl--parseandjustl-exec-eshellfunctions so that arguments are ordered correctly when calling just: arguments which are destined for just (as in the executable) should be defined before the recipe, since the recipe can have its own arguments.