Promote justl--justfile to a safe, local defcustom
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d' into feature/make-justl-justfile-a-safe-buffer-local-var
johnhamelink
force-pushed
the
feature/make-justl-justfile-a-safe-buffer-local-var
branch
from
86c5498 to
1feb09e
Compare
johnhamelink
force-pushed
the
feature/make-justl-justfile-a-safe-buffer-local-var
branch
from
86c5498 to
127c29c
Compare
johnhamelink
changed the title
justl--justfile to a safe, public varjustl--justfile to a safe, local defcustom
|
@psibi I see the latest CI ran failed because my changes are incompatible with 26.3. I've never had to deal with compatibility issues in Emacs before so I'm not sure how best to address this in way that's neat, idiomatic & acceptable. Do you have any suggestions? |
|
@johnhamelink I don't mind dropping 26.3 support. |
|
@psibi I've replaced Emacs 26 support with emacs-release-snapshot |
|
Thank you! |
johnhamelink
deleted the
feature/make-justl-justfile-a-safe-buffer-local-var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the justfile variable configurable from a
.dir-locals.elfile:I currently have a project made up of many microservices which each have their own directory, along with a directory containing a justfile. I want to be able to call the justfile from any directory under the
.dir-locals.elfile at project root.Before, I was doing this reliably by setting:
But I would receive safe variable warnings that I couldn't figure out how to suppress without making changes to the package.