Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unstable flag to transient #32

Merged
merged 3 commits into from
Jun 11, 2023

Conversation

johnhamelink
Copy link
Contributor

This PR adds the ability to define flags which are passed to the just
executable itself. This is needed if, for example, a justfile requires
the --unstable flag.

Copy link
Owner

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look into why tests are failing ? Also, can you add a test for this ?

@johnhamelink
Copy link
Contributor Author

@psibi yes, certainly! I should have a chance have a look this week at some point.

@johnhamelink johnhamelink changed the title Add ability to define args for the just command (not the recipe). Add Unstable flag to transient Jun 4, 2023
@johnhamelink johnhamelink force-pushed the feature/add-flags-to-just-command branch from 57e6f18 to d23b95f Compare June 4, 2023 18:02
@johnhamelink
Copy link
Contributor Author

johnhamelink commented Jun 4, 2023

Hi, after some more reading and understanding of the code, I realised I didn't need to reinvent the wheel - I could make use of transient's saving feature to get the results I wanted, so long as transient arguments would also be applied to the list function. I've tested it thoroughly and couldn't trigger any issue with this approach.

20230604_19h04m49s_grim

@johnhamelink johnhamelink force-pushed the feature/add-flags-to-just-command branch from cd5b106 to 3abda3b Compare June 4, 2023 18:47
@psibi
Copy link
Owner

psibi commented Jun 8, 2023

@johnhamelink I guess we can close this PR then? Do you think we can document what you did via transient in the README.org ?

@johnhamelink
Copy link
Contributor Author

@psibi I force-pushed some changes to this repo which I think are still valid, but yes I think we should link to this section of the transient docs: https://www.gnu.org/software/emacs//manual/html_node/transient/Saving-Values.html

@psibi psibi merged commit a85d81d into psibi:master Jun 11, 2023
@psibi
Copy link
Owner

psibi commented Jun 11, 2023

Thank you!

@johnhamelink johnhamelink deleted the feature/add-flags-to-just-command branch June 11, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants