-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unstable flag to transient #32
Add Unstable flag to transient #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look into why tests are failing ? Also, can you add a test for this ?
@psibi yes, certainly! I should have a chance have a look this week at some point. |
57e6f18
to
d23b95f
Compare
Hi, after some more reading and understanding of the code, I realised I didn't need to reinvent the wheel - I could make use of transient's saving feature to get the results I wanted, so long as transient arguments would also be applied to the list function. I've tested it thoroughly and couldn't trigger any issue with this approach. |
cd5b106
to
3abda3b
Compare
@johnhamelink I guess we can close this PR then? Do you think we can document what you did via transient in the |
@psibi I force-pushed some changes to this repo which I think are still valid, but yes I think we should link to this section of the transient docs: https://www.gnu.org/software/emacs//manual/html_node/transient/Saving-Values.html |
Thank you! |
This PR adds the ability to define flags which are passed to the just
executable itself. This is needed if, for example, a justfile requires
the
--unstable
flag.