Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for doom config #27

Merged
merged 3 commits into from
Sep 22, 2022
Merged

add example for doom config #27

merged 3 commits into from
Sep 22, 2022

Conversation

vmiheer
Copy link
Contributor

@vmiheer vmiheer commented Sep 19, 2022

No description provided.

@vmiheer
Copy link
Contributor Author

vmiheer commented Sep 19, 2022

Ideally it should be implemented as in https://github.com/emacs-evil/evil-collection (also see #15).

@psibi
Copy link
Owner

psibi commented Sep 19, 2022

Thanks! Do you think you can probably also send a PR to evil-collection ?

@@ -32,6 +32,15 @@ Optionally you can install it via [[https://github.com/quelpa/quelpa][quelpa]] t
(justl-recipe-width 25))
#+end_example

For [[https://github.com/doomemacs/doomemacs][doom emacs]], you can install as:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this primarily for doom emacs or for integration with evil mode ? I'm slightly confused as I have no idea about either of them. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That particular change is only for doom emacs. I'll try to eventually (tm) create PR in evil-collection.

Copy link
Owner

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, LGTM apart from that.

README.org Outdated Show resolved Hide resolved
Co-authored-by: Sibi Prabakaran <[email protected]>
README.org Outdated Show resolved Hide resolved
@vmiheer vmiheer requested a review from psibi September 21, 2022 21:58
@psibi psibi merged commit 4dc372c into psibi:master Sep 22, 2022
@psibi
Copy link
Owner

psibi commented Sep 22, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants