Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates conda environments for CI #89

Merged
merged 2 commits into from
May 6, 2024
Merged

Updates conda environments for CI #89

merged 2 commits into from
May 6, 2024

Conversation

AlexHeide
Copy link
Collaborator

Remove references to old psi4 conda channel
Update dftd3 packages used for testing

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.71%. Comparing base (fb3d2c6) to head (63e7477).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   83.48%   83.71%   +0.23%     
==========================================
  Files          35       35              
  Lines        6831     6842      +11     
==========================================
+ Hits         5703     5728      +25     
+ Misses       1128     1114      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

psi-rking
psi-rking previously approved these changes May 2, 2024
@psi-rking
Copy link
Owner

@AlexHeide , Are you ready to merge?

@loriab loriab mentioned this pull request May 2, 2024
@AlexHeide
Copy link
Collaborator Author

Upgrading to codecov v4 and adopting the auth tokens seems to have worked. Issue seems related to: codecov/engineering-team#1574

Shall we can close this PR in favor of Lori's and add the codecov updates there?

@loriab
Copy link
Collaborator

loriab commented May 2, 2024

Shall we can close this PR in favor of Lori's and add the codecov updates there?

I can confirm that dftd3-python pkg brings simple-dftd3 as a dep. I noticed locally that you might be looking for which dftd3 somewhere, and that should probably get updated to which s-dftd3 or both.

@loriab
Copy link
Collaborator

loriab commented May 2, 2024

I'm also glad to rebase mine after this is merged.

@AlexHeide
Copy link
Collaborator Author

@loriab Do you remember the context where you ran into optking trying to check for dftd3 or execute dftd3? I can't find any references in optking at least to dftd3 outside of the conda-envs.

@loriab
Copy link
Collaborator

loriab commented May 2, 2024

[gw3] [ 95%] FAILED optking/tests/test_dimers_mt_tyr_Rscan.py::test_dimers_mt_tyr_Rscan 
[gw3] [ 95%] FAILED optking/tests/test_dimers_mt_tyr_frozen_orientation.py::test_dimers_mt_tyr_frozen_orientation 

I'm in a weird dev setup (wip qcng, optking, psi4), so if you don't see an error, it's probably fine in optking, and just a loose connection on my end.

@psi-rking psi-rking merged commit c23b5ed into master May 6, 2024
8 of 9 checks passed
@psi-rking psi-rking deleted the gh_actions branch May 6, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants