Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable requests[security] and remove 3.5 support references #5867

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

nateprewitt
Copy link
Member

requests[security]

This PR will remove functionality from the requests[security] extra. We initially removed default support for PyOpenSSL in Requests 2.24.0 (#5443) as it is now considered less secure. Deprecation of the extras_require was announced in Requests 2.25.0 and we're officially removing the extras_require functionality in Requests 2.26.0.

Projects currently using requests[security] after this change will continue to operate as if performing a standard requests installation (secure by default).

While not recommended, if PyOpenSSL support is still a requirement in your project, you may install urllib3[secure] and add urllib3.contrib.pyopenssl.inject_into_urllib3() to your code to re-enable the functionality.

Python 3.5 Support

We will also be removing support for Python 3.5 in Requests 2.26.0 as announced in the 2.25.0 release notes.

@nateprewitt nateprewitt requested a review from sethmlarson July 9, 2021 19:09
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing I found was we should update python_requires to add !=3.5.*

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nateprewitt nateprewitt merged commit f6c0619 into psf:master Jul 9, 2021
@nateprewitt nateprewitt deleted the 2_26_0_cleanup branch July 9, 2021 19:40
@nateprewitt nateprewitt mentioned this pull request Jul 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants