Smaller logo #3901
Smaller logo #3901
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3901 +/- ##
==========================================
+ Coverage 89.17% 89.32% +0.15%
==========================================
Files 15 15
Lines 1940 1940
==========================================
+ Hits 1730 1733 +3
+ Misses 210 207 -3
Continue to review full report at Codecov.
|
README.rst
Outdated
| @@ -50,7 +50,7 @@ Behold, the power of Requests: | |||
|
|
|||
| See `the similar code, sans Requests <https://gist.github.com/973705>`_. | |||
|
|
|||
| .. image:: http://docs.python-requests.org/en/master/_static/requests-sidebar.png | |||
| .. image:: https://raw.githubusercontent.com/nedbat/requests/master/docs/_static/requests-logo-small.png | |||
| :target: http://docs.python-requests.org/ | |||
There was a problem hiding this comment.
This should probably be pointed into our copy of the repo, not yours. 😉
There was a problem hiding this comment.
I know, i mentioned that on the pull request. :) If I made it point to kenneth's now, I wouldn't be able to see it in my repo, and neither would you :)
There was a problem hiding this comment.
I can change the URL now in the PR if you like, or fix it afterwards.
There was a problem hiding this comment.
Let's fix it now. I don't like adding extra commits if I can avoid it. 😆
|
Nice first commit, thanks @nedbat! |
The logo as-is is too large, it won't even fit on my screen!
I made a smaller version for use in the README.rst, because GitHub has neutered some useful features and doesn't care: github/markup#295
NOTE: the image path is to my fork. Once merged, the path should be changed to refer to the main repo.