-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import native Python JSON only #3056
Conversation
LGTM. |
Import native Python JSON only
✨ 🍰 ✨ |
Really, no longer a need for But, that would require touching a lot more code. |
@kennethreitz I actually was going to rename complexjson to json but there are json variable references all over the models.py file and decided it was probably best not to refactor it. If you still think it's a good idea I'm game to change it. |
Perhaps there a different name we could use for the import so it would require less touching of code. |
Ah, prob best to It's a clever name, and I enjoy cleverness. |
Ha! Agreed, complexjson is a good alt name. Best to either change it to json or leave it as is. |
PR looks perfect. |
The reason we need That said, I'm open to changing it to one of the following
And probably quite a few other names. ;) |
|
|
No, it's fine as is. |
I know. I'm just kidding about alternate names. Alternatively
|
|
I got it ...
You guys are gonna delete the PR now aren't you :( |
TrumpJSON™: It's unbelievable, really, the best JSON you'll ever experience. Trust me, I know JSON. |
It overwrites all your code with this way better code, trust me it's better.... |
It's a huuuuuuuuuuuuuuuuuuge download. It makes serialization great again |
anyway this can get in a 2.x release? It's been two years now and |
Pull Request derived from the discussion on issue #3052