Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import native Python JSON only #3056

Merged
merged 1 commit into from
Mar 16, 2016

Conversation

digitaldavenyc
Copy link

Pull Request derived from the discussion on issue #3052

@Lukasa
Copy link
Member

Lukasa commented Mar 16, 2016

LGTM.

sigmavirus24 added a commit that referenced this pull request Mar 16, 2016
@sigmavirus24 sigmavirus24 merged commit 0acbf2b into psf:proposed/3.0.0 Mar 16, 2016
@sigmavirus24
Copy link
Contributor

✨ 🍰 ✨

@kennethreitz
Copy link
Contributor

Really, no longer a need for json to be in compat at all anymore, let alone be called complexjson.

But, that would require touching a lot more code.

@digitaldavenyc
Copy link
Author

@kennethreitz I actually was going to rename complexjson to json but there are json variable references all over the models.py file and decided it was probably best not to refactor it. If you still think it's a good idea I'm game to change it.

@digitaldavenyc
Copy link
Author

Perhaps there a different name we could use for the import so it would require less touching of code. jsonp?

@kennethreitz
Copy link
Contributor

Ah, prob best to import json as complexjson in models.py then (instead of compat.py).

It's a clever name, and I enjoy cleverness.

@digitaldavenyc
Copy link
Author

Ha! Agreed, complexjson is a good alt name. Best to either change it to json or leave it as is.

@kennethreitz
Copy link
Contributor

PR looks perfect.

@sigmavirus24
Copy link
Contributor

The reason we need complexjson in models.py is because we accept json as a method/function parameter and for those cases we can't also reference json the module without a name collision. Leaving it as such makes life a bit simpler.

That said, I'm open to changing it to one of the following

  • loljson
  • whyjson
  • hailjson
  • zomgjson
  • whatevenisjson

And probably quite a few other names. ;)

@kennethreitz
Copy link
Contributor

  • mwson (micro web services object notation)

@kennethreitz
Copy link
Contributor

  • perhapsjson
  • itcouldbejson
  • pleasedontsayjason

@kennethreitz
Copy link
Contributor

No, it's fine as is.

@sigmavirus24
Copy link
Contributor

I know. I'm just kidding about alternate names. Alternatively

  • mycathatesjson
  • oneweirdtrickforserializinganddeserializingjson

@kennethreitz
Copy link
Contributor

  • magicjson
  • sacredjson
  • chopjsoncarrywater
  • cosmicjson

@digitaldavenyc
Copy link
Author

I got it ...

  • trumpjson

You guys are gonna delete the PR now aren't you :(

@kennethreitz
Copy link
Contributor

TrumpJSON™: It's unbelievable, really, the best JSON you'll ever experience. Trust me, I know JSON.

@digitaldavenyc
Copy link
Author

It overwrites all your code with this way better code, trust me it's better....

@sigmavirus24
Copy link
Contributor

It's a huuuuuuuuuuuuuuuuuuge download. It makes serialization great again

@crccheck
Copy link

crccheck commented Apr 26, 2018

anyway this can get in a 2.x release? It's been two years now and simplejson is even less relevant than when this was authored

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants