Issue #749: Add optional SNI support for python2. #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SNI support will be enabled for python2 if ndg-httpsclient and pyopenssl are available.
|
Is that seriously all that's needed to set up SNI support in it's totality? |
Closed
|
@sigmavirus24: If it is that's awesome. |
|
Yes. It's merely disabled in urllib3 by default due to the additional requirements and due to the fact that ssl is way more tested than pyopenssl. That's why they've kept it in the |
|
Then I'm 👍 on this. |
|
🍰 |
kennethreitz
pushed a commit
that referenced
this pull request
May 4, 2013
Issue #749: Add optional SNI support for python2.
mtigas
referenced
this pull request
in CivOmega/civomega
Feb 7, 2015
per https://www.ssllabs.com/ssltest/analyze.html?d=congress.api.sunlightfoundation.com&hideResults=on , sunlight's servers are configured such that only TLS clients that support SNI (basically having multiple SSL domain names supported within one ip address) can access the API server. unfortunately, most (all?) installs of python 2.7.8 and earlier don't support SNI. but support can be enabled by installing pyopenssl <https://github.com/pyca/pyopenssl> & some other stuff, see: * http://stackoverflow.com/a/18579484 * kennethreitz/requests#1347
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNI support will be enabled for python2 if ndg-httpsclient and pyopenssl are available.