Rebased elnuno's fix and retested: "Close CallbackFileWrapper.__buf once it's used." #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed it hadn't been updated in a while so I just pulled it down and rebased it on the latest master, and re-tested it using the script @elnuno used (and
pytest
).With @elnuno 's change (and a ~70mb file):
Without:
This is exactly the same changes as in:
#152
Just rebased as @ionrock had requested in 2018 with the hope of it getting merged.
EDIT: Obviously I don't deserve any credit for this, just trying to help get @elnuno 's fix in.