Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased elnuno's fix and retested: "Close CallbackFileWrapper.__buf once it's used." #254

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

dwillie
Copy link

@dwillie dwillie commented Sep 27, 2021

I noticed it hadn't been updated in a while so I just pulled it down and rebased it on the latest master, and re-tested it using the script @elnuno used (and pytest).

With @elnuno 's change (and a ~70mb file):

Using 36 MB on program end.
Mean memory use: 26 MB

Without:

Using 77 MB on program end.
Mean memory use: 189 MB

This is exactly the same changes as in:
#152

Just rebased as @ionrock had requested in 2018 with the hope of it getting merged.

EDIT: Obviously I don't deserve any credit for this, just trying to help get @elnuno 's fix in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants