Fix trailing comma for function with one arg (#880) #891
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djb7
force-pushed
the
bugfix/880-trailing-comma-for-function-with-one-arg
branch
from
781b6a2 to
c7943f2
Compare
|
(ref. issue #880 ) |
JelleZijlstra
requested changes
Jun 9, 2019
black.py
Outdated
| if original.is_import: | ||
| # Ensure a trailing comma for imports and standalone function arguments, but | ||
| # be careful not to add one after any comments. | ||
| no_commas = original.is_def and not [ |
tests/test_black.py
Outdated
| @@ -264,6 +264,14 @@ def test_function2(self) -> None: | |||
| black.assert_equivalent(source, actual) | |||
| black.assert_stable(source, actual, black.FileMode()) | |||
|
|
|||
| @patch("black.dump_to_file", dump_to_stderr) | |||
| def test_function3(self) -> None: | |||
There was a problem hiding this comment.
It's fine to have another test file, but could you name it something less generic, like test_function_trailing_comma?
Modified maybe_remove_trailing_comma to remove trailing commas for typedarglists (in addition to arglists), and updated line split logic to ensure that all lines in a function definition that contain only one arg have a trailing comma.
djb7
force-pushed
the
bugfix/880-trailing-comma-for-function-with-one-arg
branch
from
c7943f2 to
7e822f3
Compare
zsol
approved these changes
Jun 15, 2019
JelleZijlstra
approved these changes
Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified maybe_remove_trailing_comma to remove trailing commas for typedarglists (in addition to arglists), and updated line split logic to ensure that all lines in a function definition that contain only one arg have a trailing comma.
Some discussion points:
no_commas. Would be great to hear any other suggestions for this test.