Update isort config to use_parentheses instead of combine_as_imports #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `combine_as_imports=True` modifies isort style as a side-effect and was not the intended purpose of the suggested change in psf#250. The problem was that isort was actually replacing the parens with backslash and using `combine_as_imports=True` happened to also produce the same result. The actual setting should be `use_parentheses` as this tells isort to use parenthesis for line continuation instead of \ for lines over the allotted line length limit and matches precisely what black is outputting.
Pull Request Test Coverage Report for Build 773
💛 - Coveralls |
|
Can this be reviewed for merging? |
|
@ambv Please can you review this PR |
|
Anyone? |
|
Thanks! ✨ 🍰 ✨ |
jleclanche
pushed a commit
to jleclanche/tan
that referenced
this pull request
Nov 14, 2018
…sf#547) The `combine_as_imports=True` modifies isort style as a side-effect and was not the intended purpose of the suggested change in psf#250. The problem was that isort was actually replacing the parens with backslash and using `combine_as_imports=True` happened to also produce the same result. The actual setting should be `use_parentheses` as this tells isort to use parenthesis for line continuation instead of \ for lines over the allotted line length limit and matches precisely what black is outputting. (cherry picked from commit 158f796)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
combine_as_imports=Truemodifies isort style as a side-effect and was not the intended purpose of the suggested change in #250. The problem was that isort was actually replacing the parens with backslash and usingcombine_as_imports=Truehappened to also produce the same result.The actual setting should be
use_parenthesesas this tells isort to use parenthesis for line continuation instead of \ for lines over the allotted line length limit and matches precisely what black is outputting.