Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(🐞) blackd: fix issue for mishandling single character input #3558

Merged
merged 3 commits into from
Sep 7, 2023
Merged

(🐞) blackd: fix issue for mishandling single character input #3558

merged 3 commits into from
Sep 7, 2023

Conversation

KotlinIsland
Copy link
Contributor

@KotlinIsland KotlinIsland commented Feb 10, 2023 •
edited
Loading

Description

I found this ladybug where if you send one character to blackd it will 500 😳. I created this defect in #3257

Checklist - did you ...

  • [🚀] Add an entry in CHANGES.md if necessary?
  • [🚀] Add / update tests if necessary?
  • [🚀] Add new / update outdated documentation?

❓ Question

Why is the blackd section of CHANGES.md italic?

@github-actions
Copy link

github-actions bot commented Feb 10, 2023 •
edited
Loading

diff-shades reports zero changes comparing this PR (3629df9) to main (df50fee).

What is this? | Workflow run | diff-shades documentation

@cooperlees cooperlees requested a review from zsol February 10, 2023 01:33
zsol
zsol reviewed Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Changes look good after removing that del

src/blackd/__init__.py Outdated Show resolved Hide resolved
zsol
zsol reviewed Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh one more thing, could you please add a simple test case for this?

@zsol
Copy link
Collaborator

zsol commented Feb 13, 2023

Looks like the test is failing

@ichard26 ichard26 added the S: awaiting response Waiting for futher information from OP label Feb 14, 2023
@KotlinIsland
Copy link
Contributor Author

@zsol Sorry! this must have fell off my radar somehow.

hauntsaninja
hauntsaninja reviewed Sep 7, 2023
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
hauntsaninja
hauntsaninja approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja merged commit 8daa64a into psf:main Sep 7, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@zsol zsol Awaiting requested review from zsol

Assignees
No one assigned
Labels
S: awaiting response Waiting for futher information from OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KotlinIsland @zsol @hauntsaninja @ichard26