-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft for Black 2023 stable style #3418
Conversation
This reverts commit b6cd780.
I ran this on our internal codebase and was pretty happy with the result. Most of the changes I saw were removing blank lines (#3035). This PR currently leaves #3044 and experimental string processing in preview. I'll defer working on this PR more (e.g., getting tests to pass) until my other PRs from today are merged. |
This reverts commit bce883b.
CI is green now apart from diff-shades telling me I changed the stable style, which is expected since that's the point of this PR. I think tomorrow I'll cut a 23.1a1 release off this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there. Just one more day and then 23.1.0 will be out.
PR looks good, although I think you can delete everything under this header. You might want to keep/move the "Improved empty line management" stuff to the stable docs though as subpoint 1 could surprise some people.
Sounds like it should be named 23.2.0 ;) |
As long as it's still January in California when we release it I'm calling it 23.1.0 :) |
This shouldn't be merged before 2023 (in case we want to do another 22.12 release) and shouldn't be merged until we have consensus in #3407. I'm opening it so I can evaluate the effect of the draft 2023 style without the obviously problematic bits.
Closes #3407
TODO: