-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap concatenated strings used as function args in parens. #3307
Conversation
diff-shades results comparing this PR (5f4e810) to main (09d4acd). The full diff is available in the logs under the "Generate HTML diff report" step.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the diff-shades output I'm still a bit nervous whether this is a net positive, since it does often feel like it's adding unnecessary lines. But I guess that's what we have a preview style for.
Updated, please take another look. Thanks Jelle! |
…l" section. psf#3307 is merged. PiperOrigin-RevId: 496442325
Description
This implements #3292.
I have only heard one 👍 from @felix-hilden. But I think it's also easier to decide after seeing the formatting changes introduced by this PR, thus I'm sending it now so we can visualize the diffs.
Checklist - did you ...
CHANGES.md
if necessary?