-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing wheels for Python 3.7 and 3.8 #1385
Comments
@ckataki Is there a specific use case where a py37 or py38 specific wheel is required to install Black 19.10b0 on Python37 or Python38? The available wheel for Black 19.10b0 is a Pure Python wheel, meaning that installers can if necessary, fall back to a wheel built for an older version of Python. Quoting from PEP 425 (which describes the naming of wheels):
Admittedly, I don't know much about packaging for Python for platforms other than Windows. More context about your use case would be appreciated. |
Confirmed it uses $ python --version
Python 3.8.2
$ pip uninstall -y black
Found existing installation: black 19.10b0
Uninstalling black-19.10b0:
Successfully uninstalled black-19.10b0
$ pip install --no-cache-dir black
Collecting black
Downloading black-19.10b0-py36-none-any.whl (97 kB)
|████████████████████████████████| 97 kB 1.7 MB/s
Requirement already satisfied: regex in /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages (from black) (2020.1.8)
Requirement already satisfied: appdirs in /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages (from black) (1.4.3)
Requirement already satisfied: attrs>=18.1.0 in /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages (from black) (19.3.0)
Requirement already satisfied: click>=6.5 in /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages (from black) (7.1.2)
Requirement already satisfied: pathspec<1,>=0.6 in /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages (from black) (0.7.0)
Requirement already satisfied: toml>=0.9.4 in /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages (from black) (0.10.0)
Requirement already satisfied: typed-ast>=1.4.0 in /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages (from black) (1.4.1)
Installing collected packages: black
Successfully installed black-19.10b0 |
I think this is more an issue with
As you can see above, this is an issue with pip 19.0.3, but not with pip 20.1. Given that version 20 is fairly new (at least from the perspective of enterprises), upgrades can be slow. |
If that's the case I'd like to suggest we should just drop explicit version wheels and return to the usual To make a normal Happy to do the PR is we all agree. |
@cooperlees I agree, makes sense. |
- This makes black wheels to be tagged as py3 default - `python_requires=">=3.6"` ensures we are >= 3.6 Test: ``` python3 -m venv /tmp/build_black /tmp/build_black/bin/pip install --upgrade pip setuptools wheel /tmp/build_black/bin/python setup.py bdist_wheel ... black-19.10b1.dev53+g81bf9bb.d20200508-py3-none-any.whl ``` Addresses #1385
- This makes black wheels to be tagged as py3 default - `python_requires=">=3.6"` ensures we are >= 3.6 Test: ``` python3 -m venv /tmp/build_black /tmp/build_black/bin/pip install --upgrade pip setuptools wheel /tmp/build_black/bin/python setup.py bdist_wheel ... black-19.10b1.dev53+g81bf9bb.d20200508-py3-none-any.whl ``` Addresses #1385
Describe the bug
Black only provides Python 3.6 wheels for the latest version (19.10b0). There should be 3.7 and 3.8 wheels made available as well.
To Reproduce
Expected behavior
Wheels should be available for py37 and py38 as well
Environment
Does this bug also happen on master?
N/A
Additional context
Version 18.3a1 (https://pypi.org/project/black/18.3a1/#files) has a py3 wheel, which makes it compatible with all Python3 interpreters. The move to a py36 wheel is understandable (to enforce Black's Python >= 3.6 requirement as I understand), but without additional wheels we cannot use it with Python 3.7.
The text was updated successfully, but these errors were encountered: