Skip to content

Commit

Permalink
Support multiple top-level as-expressions on case statements (#2716)
Browse files Browse the repository at this point in the history
  • Loading branch information
isidentical authored Dec 21, 2021
1 parent c758126 commit 3fafd80
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
underlying SyntaxError (#2693)
- Fix mapping cases that contain as-expressions, like `case {"key": 1 | 2 as password}`
(#2686)
- Fix cases that contain multiple top-level as-expressions, like `case 1 as a, 2 as b`
(#2716)
- No longer color diff headers white as it's unreadable in light themed terminals
(#2691)
- Tuple unpacking on `return` and `yield` constructs now implies 3.8+ (#2700)
Expand Down
4 changes: 2 additions & 2 deletions src/blib2to3/Grammar.txt
Original file line number Diff line number Diff line change
Expand Up @@ -247,5 +247,5 @@ subject_expr: (namedexpr_test|star_expr) (',' (namedexpr_test|star_expr))* [',']
# cases
case_block: "case" patterns [guard] ':' suite
guard: 'if' namedexpr_test
patterns: pattern ['as' pattern]
pattern: (expr|star_expr) (',' (expr|star_expr))* [',']
patterns: pattern (',' pattern)* [',']
pattern: (expr|star_expr) ['as' expr]
11 changes: 11 additions & 0 deletions tests/data/pattern_matching_extras.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,14 @@ def func(match: case, case: match) -> case:
pass
case {"maybe": something(complicated as this) as that}:
pass


match something:
case 1 as a:
pass

case 2 as b, 3 as c:
pass

case 4 as d, (5 as e), (6 | 7 as g), *h:
pass

0 comments on commit 3fafd80

Please sign in to comment.