Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash Pubsub Messages Correctly #7177

Merged
merged 7 commits into from
Sep 6, 2020
Merged

Hash Pubsub Messages Correctly #7177

merged 7 commits into from
Sep 6, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Sep 4, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Fixes hashing of pubsub messages. We were using highway hash instead of sha256 and used the padded version of
    the base64 url encoding.
  • Add a regression test for this exact configuration for our msgID function.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner September 4, 2020 13:17
@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #7177 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7177      +/-   ##
==========================================
+ Coverage   61.64%   61.75%   +0.11%     
==========================================
  Files         410      410              
  Lines       32540    32674     +134     
==========================================
+ Hits        20059    20178     +119     
- Misses       9617     9622       +5     
- Partials     2864     2874      +10

prestonvanloon
prestonvanloon reviewed Sep 4, 2020
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Are there any concerns about when we should release this change?

shayzluf
shayzluf approved these changes Sep 6, 2020
View reviewed changes
Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nisdas nisdas merged commit a812142 into master Sep 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the hashMsgID branch September 6, 2020 18:05
@blacktemplar blacktemplar mentioned this pull request Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon left review comments

@terencechain terencechain terencechain approved these changes

@shayzluf shayzluf shayzluf approved these changes

@farazdagi farazdagi Awaiting requested review from farazdagi

@rauljordan rauljordan Awaiting requested review from rauljordan

@rkapka rkapka Awaiting requested review from rkapka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nisdas @shayzluf @prestonvanloon @terencechain