Update to go 1.14

WORKSPACE

@@ -52,10 +52,10 @@ http_archive(
 
 http_archive(
     name = "bazel_gazelle",
-    sha256 = "86c6d481b3f7aedc1d60c1c211c6f76da282ae197c3b3160f54bd3a8f847896f",
+    sha256 = "d8c45ee70ec39a57e7a05e5027c32b1576cc7f16d9dd37135b0eddde45cf1b10",
     urls = [
-        "https://storage.googleapis.com/bazel-mirror/github.com/bazelbuild/bazel-gazelle/releases/download/v0.19.1/bazel-gazelle-v0.19.1.tar.gz",
-        "https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.19.1/bazel-gazelle-v0.19.1.tar.gz",
+        "https://storage.googleapis.com/bazel-mirror/github.com/bazelbuild/bazel-gazelle/releases/download/v0.20.0/bazel-gazelle-v0.20.0.tar.gz",
+        "https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.20.0/bazel-gazelle-v0.20.0.tar.gz",
     ],
 )
 
@@ -75,10 +75,10 @@ http_archive(
 
 http_archive(
     name = "io_bazel_rules_go",
-    sha256 = "e88471aea3a3a4f19ec1310a55ba94772d087e9ce46e41ae38ecebe17935de7b",
+    sha256 = "e6a6c016b0663e06fa5fccf1cd8152eab8aa8180c583ec20c872f4f9953a7ac5",
     urls = [
-        "https://storage.googleapis.com/bazel-mirror/github.com/bazelbuild/rules_go/releases/download/v0.20.3/rules_go-v0.20.3.tar.gz",
-        "https://github.com/bazelbuild/rules_go/releases/download/v0.20.3/rules_go-v0.20.3.tar.gz",
+        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.22.1/rules_go-v0.22.1.tar.gz",
+        "https://github.com/bazelbuild/rules_go/releases/download/v0.22.1/rules_go-v0.22.1.tar.gz",
     ],
 )
 
@@ -628,8 +628,9 @@ go_repository(
 
 go_repository(
     name = "org_golang_x_crypto",
-    commit = "4def268fd1a49955bfb3dda92fe3db4f924f2285",
     importpath = "golang.org/x/crypto",
+    sum = "h1:1ZiEyfaQIg3Qh0EoqpwAakHVhecoE5wlSg5GjnafJGw=",
+    version = "v0.0.0-20200221231518-2aa609cf4a9d",
 )
 
 go_repository(
@@ -755,10 +756,12 @@ go_repository(
     importpath = "github.com/matttproud/golang_protobuf_extensions",
 )
 
-go_repository(
-    name = "com_github_boltdb_bolt",
-    commit = "2f1ce7a837dcb8da3ec595b1dac9d0632f0f99e8",  # v1.3.1
-    importpath = "github.com/boltdb/bolt",
+http_archive(
+    name = "com_github_boltdb_bolt",  # v1.3.1
+    build_file = "//third_party:boltdb/bolt.BUILD",
+    sha256 = "95dc5842dab55f7519b7002bbec648321277b5d6f0ad59aab509ee59313b6386",
+    strip_prefix = "bolt-2f1ce7a837dcb8da3ec595b1dac9d0632f0f99e8",
+    urls = ["https://github.com/boltdb/bolt/archive/2f1ce7a837dcb8da3ec595b1dac9d0632f0f99e8.tar.gz"],
 )
 
 go_repository(
@@ -1200,8 +1203,9 @@ go_ssz_dependencies()
 go_repository(
     name = "org_golang_google_grpc",
     build_file_proto_mode = "disable",
-    commit = "1d89a3c832915b2314551c1d2a506874d62e53f7",  # v1.22.0
     importpath = "google.golang.org/grpc",
+    sum = "h1:zvIju4sqAGvwKspUQOhwnpcqSbzi7/H6QomNNjTL4sk=",
+    version = "v1.27.1",
 )
 
 go_repository(

beacon-chain/blockchain/BUILD.bazel

@@ -115,6 +115,13 @@ go_test(
         "service_norace_test.go",
     ],
     embed = [":go_default_library"],
+    gc_goopts = [
+        # Go 1.14 enables checkptr by default when building with -race or -msan. There is a pointer
+        # issue in boltdb, so must disable checkptr at compile time. This flag can be removed once
+        # the project is migrated to etcd's version of boltdb and the issue has been fixed.
+        # See: https://github.com/etcd-io/bbolt/issues/187.
+        "-d=checkptr=0",
+    ],
     race = "on",
     tags = ["race_on"],
     deps = [

beacon-chain/operations/attestations/BUILD.bazel

@@ -20,7 +20,7 @@ go_library(
         "//shared/hashutil:go_default_library",
         "//shared/params:go_default_library",
         "//shared/roughtime:go_default_library",
-        "@com_github_dgraph_io_ristretto//:go_default_library",
+        "@com_github_hashicorp_golang_lru//:go_default_library",
         "@com_github_prometheus_client_golang//prometheus:go_default_library",
         "@com_github_prometheus_client_golang//prometheus/promauto:go_default_library",
         "@com_github_prysmaticlabs_ethereumapis//eth/v1alpha1:go_default_library",

beacon-chain/operations/attestations/prepare_forkchoice.go

@@ -1,6 +1,7 @@
 package attestations
 
 import (
+	"bytes"
 	"context"
 	"errors"
 	"time"
@@ -108,22 +109,22 @@ func (s *Service) seen(att *ethpb.Attestation) (bool, error) {
 		return false, err
 	}
 	incomingBits := att.AggregationBits
-	savedBits, ok := s.forkChoiceProcessedRoots.Get(string(attRoot[:]))
+	savedBits, ok := s.forkChoiceProcessedRoots.Get(attRoot)
 	if ok {
 		savedBitlist, ok := savedBits.(bitfield.Bitlist)
 		if !ok {
 			return false, errors.New("not a bit field")
 		}
 		if savedBitlist.Len() == incomingBits.Len() {
 			// Returns true if the node has seen all the bits in the new bit field of the incoming attestation.
-			if savedBitlist.Contains(incomingBits) {
+			if bytes.Equal(savedBitlist, incomingBits) || savedBitlist.Contains(incomingBits) {
 				return true, nil
 			}
 			// Update the bit fields by Or'ing them with the new ones.
 			incomingBits = incomingBits.Or(savedBitlist)
 		}
 	}
 
-	s.forkChoiceProcessedRoots.Set(string(attRoot[:]), incomingBits, 1 /*cost*/)
+	s.forkChoiceProcessedRoots.Add(attRoot, incomingBits)
 	return false, nil
 }

beacon-chain/operations/attestations/prepare_forkchoice_test.go

@@ -5,7 +5,6 @@ import (
 	"reflect"
 	"sort"
 	"testing"
-	"time"
 
 	"github.com/gogo/protobuf/proto"
 	ethpb "github.com/prysmaticlabs/ethereumapis/eth/v1alpha1"
@@ -172,7 +171,7 @@ func TestBatchAttestations_Single(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	wanted, err := helpers.AggregateAttestations(append(unaggregatedAtts, aggregatedAtts...))
+	wanted, err := helpers.AggregateAttestations(append(aggregatedAtts, unaggregatedAtts...))
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -182,7 +181,8 @@ func TestBatchAttestations_Single(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	if !reflect.DeepEqual(wanted, s.pool.ForkchoiceAttestations()) {
+	got := s.pool.ForkchoiceAttestations()
+	if !reflect.DeepEqual(wanted, got) {
 		t.Error("Did not aggregate and save for batch")
 	}
 }
@@ -296,8 +296,6 @@ func TestSeenAttestations_PresentInCache(t *testing.T) {
 		t.Error("Wanted false, got true")
 	}
 
-	time.Sleep(100 * time.Millisecond)
-
 	att2 := &ethpb.Attestation{Data: &ethpb.AttestationData{}, Signature: []byte{'A'}, AggregationBits: bitfield.Bitlist{0x17} /* 0b00010111 */}
 	got, err = s.seen(att2)
 	if err != nil {
@@ -307,8 +305,6 @@ func TestSeenAttestations_PresentInCache(t *testing.T) {
 		t.Error("Wanted false, got true")
 	}
 
-	time.Sleep(100 * time.Millisecond)
-
 	att3 := &ethpb.Attestation{Data: &ethpb.AttestationData{}, Signature: []byte{'A'}, AggregationBits: bitfield.Bitlist{0x17} /* 0b00010111 */}
 	got, err = s.seen(att3)
 	if err != nil {
@@ -382,6 +378,5 @@ func TestService_seen(t *testing.T) {
 		if got != tt.want {
 			t.Errorf("Test %d failed. Got=%v want=%v", i, got, tt.want)
 		}
-		time.Sleep(10) // Sleep briefly for cache to routine to buffer.
 	}
 }

beacon-chain/operations/attestations/service.go

@@ -3,19 +3,19 @@ package attestations
 import (
 	"context"
 
-	"github.com/dgraph-io/ristretto"
+	lru "github.com/hashicorp/golang-lru"
 )
 
-var forkChoiceProcessedRootsSize = int64(1 << 16)
+var forkChoiceProcessedRootsSize = 1 << 16
 
 // Service of attestation pool operations.
 type Service struct {
-	ctx                      context.Context
-	cancel                   context.CancelFunc
-	pool                     Pool
-	err                      error
-	forkChoiceProcessedRoots *ristretto.Cache
-	genesisTime              uint64
+	ctx                          context.Context
+	cancel                       context.CancelFunc
+	pool                         Pool
+	err                          error
+	forkChoiceProcessedRoots     *lru.Cache
+	genesisTime                  uint64
 }
 
 // Config options for the service.
@@ -26,11 +26,7 @@ type Config struct {
 // NewService instantiates a new attestation pool service instance that will
 // be registered into a running beacon node.
 func NewService(ctx context.Context, cfg *Config) (*Service, error) {
-	cache, err := ristretto.NewCache(&ristretto.Config{
-		NumCounters: forkChoiceProcessedRootsSize,
-		MaxCost:     forkChoiceProcessedRootsSize,
-		BufferItems: 64,
-	})
+	cache, err := lru.New(forkChoiceProcessedRootsSize)
 	if err != nil {
 		return nil, err
 	}

third_party/boltdb/bolt.BUILD

@@ -0,0 +1,61 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+# Bolt DB is an archived project which is no longer maintained. As of go 1.14,
+# the go compiler adds checkptr to all builds when using -race or -msan. Since
+# bolt DB violates this check, we must disable checkptr for this library.
+#
+# See: https://golang.org/doc/go1.14
+# See: https://github.com/etcd-io/bbolt/issues/187
+
+go_library(
+    name = "go_default_library",
+    srcs = [
+        "bolt_386.go",
+        "bolt_amd64.go",
+        "bolt_arm.go",
+        "bolt_arm64.go",
+        "bolt_linux.go",
+        "bolt_openbsd.go",
+        "bolt_ppc64.go",
+        "bolt_ppc64le.go",
+        "bolt_s390x.go",
+        "bolt_unix.go",
+        "bolt_unix_solaris.go",
+        "bolt_windows.go",
+        "boltsync_unix.go",
+        "bucket.go",
+        "cursor.go",
+        "db.go",
+        "doc.go",
+        "errors.go",
+        "freelist.go",
+        "node.go",
+        "page.go",
+        "tx.go",
+    ],
+    gc_goopts = ["-d=checkptr=0"],  # Required due to unsafe pointer usage.
+    importpath = "github.com/boltdb/bolt",
+    visibility = ["//visibility:public"],
+    deps = select({
+        "@io_bazel_rules_go//go/platform:solaris": [
+            "@org_golang_x_sys//unix:go_default_library",
+        ],
+        "//conditions:default": [],
+    }),
+)
+
+go_test(
+    name = "go_default_test",
+    srcs = [
+        "bucket_test.go",
+        "cursor_test.go",
+        "db_test.go",
+        "freelist_test.go",
+        "node_test.go",
+        "page_test.go",
+        "quick_test.go",
+        "simulation_test.go",
+        "tx_test.go",
+    ],
+    embed = [":go_default_library"],
+)