Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unskip load config tests #14539

Merged
merged 3 commits into from
Oct 15, 2024
Merged

unskip load config tests #14539

merged 3 commits into from
Oct 15, 2024

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Oct 15, 2024 •
edited
Loading

What type of PR is this?

Other

What does this PR do? Why is it needed?

load tests got commented as part of #14430 and should be added back in

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@james-prysm james-prysm added Tests Electra electra hardfork labels Oct 15, 2024
@james-prysm james-prysm requested a review from a team as a code owner October 15, 2024 19:16
@james-prysm james-prysm changed the title uncommenting lode config tests uncommenting load config tests Oct 15, 2024
@james-prysm james-prysm changed the title uncommenting load config tests unskip load config tests Oct 15, 2024
@james-prysm james-prysm enabled auto-merge October 15, 2024 21:28
@james-prysm james-prysm added this pull request to the merge queue Oct 15, 2024
Merged via the queue into develop with commit c8d3ed0 Oct 15, 2024
17 of 18 checks passed
@james-prysm james-prysm deleted the readd-config-tests-devnet4 branch October 15, 2024 21:41
@kasey kasey added the changelog/fixed Changelog Section: Fixed label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
changelog/fixed Changelog Section: Fixed Electra electra hardfork Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-prysm @terencechain @kasey