Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pubsub Library To Use Gossipsub 1.2 #14428

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Update Pubsub Library To Use Gossipsub 1.2 #14428

merged 10 commits into from
Sep 24, 2024

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Sep 6, 2024

What type of PR is this?

Dependency Update

What does this PR do? Why is it needed?

This PR is needed to allow Prysm to be updated to use Gossipsub 1.2. The changes that have been included in 1.2 are described here: libp2p/specs#548.

This has been implemeted in go-libp2p-pubsub here:
libp2p/go-libp2p-pubsub#553

Which issues(s) does this PR fix?

N.A

Other notes for review

Acknowledgements

@nisdas nisdas added the Ready For Review A pull request ready for code review label Sep 6, 2024
@nisdas nisdas requested a review from a team as a code owner September 6, 2024 10:26
nalepae
nalepae previously approved these changes Sep 6, 2024
prestonvanloon
prestonvanloon previously approved these changes Sep 6, 2024
james-prysm
james-prysm previously approved these changes Sep 6, 2024
@nisdas nisdas added this pull request to the merge queue Sep 24, 2024
Merged via the queue into develop with commit 7e5738b Sep 24, 2024
17 of 18 checks passed
@nisdas nisdas deleted the updateGoLibp2p branch September 24, 2024 16:22
Inspector-Butters pushed a commit to Inspector-Butters/prysm that referenced this pull request Sep 27, 2024
* Update Libp2p Packages

* Update CHANGELOG

* Finally Fix All Tests

* Fix Build

* Fix Build

* Fix TestP2P Connection Initialization

* Fix TestP2P Host Options

* Fix Test By Removing WaitGroup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants