-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pubsub Library To Use Gossipsub 1.2 #14428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
previously approved these changes
Sep 6, 2024
prestonvanloon
previously approved these changes
Sep 6, 2024
james-prysm
previously approved these changes
Sep 6, 2024
nisdas
dismissed stale reviews from james-prysm, prestonvanloon, and nalepae
via
September 13, 2024 05:47
4a0b1d9
nalepae
approved these changes
Sep 24, 2024
Inspector-Butters
pushed a commit
to Inspector-Butters/prysm
that referenced
this pull request
Sep 27, 2024
* Update Libp2p Packages * Update CHANGELOG * Finally Fix All Tests * Fix Build * Fix Build * Fix TestP2P Connection Initialization * Fix TestP2P Host Options * Fix Test By Removing WaitGroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Dependency Update
What does this PR do? Why is it needed?
This PR is needed to allow Prysm to be updated to use Gossipsub 1.2. The changes that have been included in 1.2 are described here: libp2p/specs#548.
This has been implemeted in
go-libp2p-pubsub
here:libp2p/go-libp2p-pubsub#553
Which issues(s) does this PR fix?
N.A
Other notes for review
Acknowledgements