Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update block's commitment size #12470

Merged
merged 2 commits into from
May 27, 2023
Merged

Update block's commitment size #12470

merged 2 commits into from
May 27, 2023

Conversation

terencechain
Copy link
Member

Implements ethereum/consensus-specs#3338

  • change MaxBlobsPerBlock from beaconconfig pkg to fieldparams pkg since it's a preset
  • add MaxBlobCommitmentsPerBlock
  • update proto/ssz_proto_library.bzl
  • update proto/prysm/v1alpha1/beacon_block.proto with max_blobs_per_block.size and max_blob_commitments.size

Note: the block gossip validation will be in another PR where we update block validation pipeline

@terencechain terencechain added Ready For Review Deneb PRs or issues for the Deneb upgrade labels May 26, 2023
@terencechain terencechain self-assigned this May 26, 2023
@terencechain terencechain requested review from prestonvanloon and a team as code owners May 26, 2023 18:56
@terencechain terencechain requested review from kasey and potuz and removed request for a team May 26, 2023 18:56
@terencechain terencechain force-pushed the max-commitment-size branch 2 times, most recently from 32c7fa7 to ce6fa05 Compare May 26, 2023 21:08
@terencechain terencechain force-pushed the max-commitment-size branch from ce6fa05 to 1a08f53 Compare May 27, 2023 00:10
@terencechain terencechain merged commit f42b326 into deneb-integration May 27, 2023
@terencechain terencechain deleted the max-commitment-size branch May 27, 2023 21:50
terencechain added a commit that referenced this pull request May 31, 2023
@terencechain
Update block's commitment size (#12470)
0c7f3cc
terencechain added a commit that referenced this pull request Jun 7, 2023
@terencechain
Update block's commitment size (#12470)
0521a84
terencechain added a commit that referenced this pull request Jun 12, 2023
@terencechain
Update block's commitment size (#12470)
c175dd6
terencechain added a commit that referenced this pull request Jun 12, 2023
@terencechain
Update block's commitment size (#12470)
865365d
terencechain added a commit that referenced this pull request Jun 16, 2023
@terencechain
Update block's commitment size (#12470)
0fcacb3
terencechain added a commit that referenced this pull request Jun 27, 2023
@terencechain
Update block's commitment size (#12470)
67ac709
terencechain added a commit that referenced this pull request Jul 7, 2023
@terencechain
Update block's commitment size (#12470)
c4e5da0
terencechain added a commit that referenced this pull request Jul 9, 2023
@terencechain
Update block's commitment size (#12470)
3995818
terencechain added a commit that referenced this pull request Jul 10, 2023
@terencechain
Update block's commitment size (#12470)
2f9ed30
kasey pushed a commit that referenced this pull request Jul 20, 2023
@terencechain @kasey
Update block's commitment size (#12470)
4d6107b
james-prysm pushed a commit that referenced this pull request Aug 4, 2023
@terencechain @james-prysm
Update block's commitment size (#12470)
a0f2bce
terencechain added a commit that referenced this pull request Aug 16, 2023
@terencechain
Update block's commitment size (#12470)
e61dd57
kasey pushed a commit that referenced this pull request Aug 21, 2023
@terencechain @kasey
Update block's commitment size (#12470)
092410c
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Update block's commitment size (#12470)
3bab035
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Update block's commitment size (#12470)
cb7ff9f
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Update block's commitment size (#12470)
7187b7b
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Update block's commitment size (#12470)
4f1c9ec
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Update block's commitment size (#12470)
7a1663f
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Update block's commitment size (#12470)
c18685b
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
Update block's commitment size (#12470)
636d014
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
Update block's commitment size (#12470)
d750a77
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Update block's commitment size (#12470)
ff69cfd
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Update block's commitment size (#12470)
5575a3f
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Update block's commitment size (#12470)
de70ad5
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Update block's commitment size (#12470)
106967f
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Update block's commitment size (#12470)
8793682
james-prysm pushed a commit that referenced this pull request Aug 25, 2023
@terencechain @james-prysm
Update block's commitment size (#12470)
4287a28
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
Update block's commitment size (#12470)
af31a20
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
Update block's commitment size (#12470)
9c13280
prestonvanloon pushed a commit that referenced this pull request Aug 31, 2023
@terencechain @prestonvanloon
Update block's commitment size (#12470)
7670fe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-prysm james-prysm james-prysm approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Deneb PRs or issues for the Deneb upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @james-prysm