Add circuit breaker for relayer/builder #11215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
Builder
james-prysm
reviewed
Aug 12, 2022
beacon-chain/node/config.go
Outdated
| @@ -65,6 +65,24 @@ func configureSafeSlotsToImportOptimistically(cliCtx *cli.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func configureMevBoostCircuitBreakerValues(cliCtx *cli.Context) error { | |||
There was a problem hiding this comment.
maybe we should name it form configureMevBoostCircuitBreakerValues toconfigureBuilderCircuitBreaker
beacon-chain/node/config.go
Outdated
| func configureMevBoostCircuitBreakerValues(cliCtx *cli.Context) error { | ||
| if cliCtx.IsSet(flags.BuilderFallbackSkips.Name) { | ||
| c := params.BeaconConfig().Copy() | ||
| c.BuilderFallbackSkipsSlot = types.Slot(cliCtx.Int(flags.BuilderFallbackSkips.Name)) |
There was a problem hiding this comment.
maybe rename to MaxBuilderConsecutiveMissedSlots telling the system that there should be a max of x slots missed before falling back to something
beacon-chain/node/config.go
Outdated
| } | ||
| if cliCtx.IsSet(flags.BuilderFallbackSkipsPerEpoch.Name) { | ||
| c := params.BeaconConfig().Copy() | ||
| c.BuilderFallbackSkipsSlotsLastEpoch = types.Slot(cliCtx.Int(flags.BuilderFallbackSkipsPerEpoch.Name)) |
There was a problem hiding this comment.
and corresponding MaxBuilderMissedSlotsInEpoch
|
|
||
| circuitBreak, err := vs.circuitBreakBuilder(b.Slot) | ||
| if err != nil { | ||
| return false, nil, errors.Wrap(err, "could not determine if builder circuit breaker condition") |
There was a problem hiding this comment.
maybe remove the if statement
| @@ -16,6 +16,16 @@ var ( | |||
| Usage: "A MEV builder relay string http endpoint, this wil be used to interact MEV builder network using API defined in: https://ethereum.github.io/builder-specs/#/Builder", | |||
| Value: "", | |||
| } | |||
| BuilderFallbackSkips = &cli.IntFlag{ | |||
| Name: "builder-fallback-skips", | |||
| Usage: "Number of consecutive skip slot to fallback from using relay/builder to local execution engine for block construction", | |||
There was a problem hiding this comment.
related to flag name changes
james-prysm
approved these changes
Aug 12, 2022
rauljordan
approved these changes
Aug 15, 2022
|
Really nice PR, thanks for putting it together in a concise manner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a circuit breaker for the builder/relayer infra to determine whether or not we should propose blocks through the builder API. This code doesn't live on the normal block proposal path, it lives in the builder block proposal path, and the risk factor is low. With that said, please careful review
The following flags are added:
--builder-fallback-skips(default value 4)the number of slots before the proposal slot that has been skipped
--builder-fallback-skips-per-epoch(default value 6)the number of slots in the last 32 slots that have been skipped
Would appreciate feedback on the defaults!