Issue validator warning when beacon node does not use builder #11203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Builder
beacon-chain/builder/service.go
Outdated
| @@ -112,7 +115,7 @@ func (s *Service) Status() error { | |||
| getStatusLatency.Observe(float64(time.Since(start).Milliseconds())) | |||
| }() | |||
|
|
|||
| // Return early if builder isn't initialized in service. | |||
| // Return early if builder isn't initilized in service. | |||
There was a problem hiding this comment.
Suggested change
| // Return early if builder isn't initilized in service. | |
| // Return early if builder isn't initialized in service. |
validator/client/registration.go
Outdated
| @@ -30,6 +32,10 @@ func SubmitValidatorRegistrations( | |||
| if _, err := validatorClient.SubmitValidatorRegistrations(ctx, ðpb.SignedValidatorRegistrationsV1{ | |||
| Messages: signedRegs, | |||
| }); err != nil { | |||
| if strings.Contains(err.Error(), builder.ErrNoBuilder.Error()) { | |||
| log.Warnln("Beacon node does not utilize a custom builder. Validator registration skipped.") | |||
There was a problem hiding this comment.
Is there anything you can add here to give information to the user on how to correct the issue? I.e. "Restart your beacon node with the --mev-relay flag" or something like that
There was a problem hiding this comment.
+1, I think more verbosity will be nice here such as validator keys and such
There was a problem hiding this comment.
I added the flag name to the log. It impacts all validator keys, so there's no need to add any.
prestonvanloon
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
UX
What does this PR do? Why is it needed?
If the validator uses
--enable-builder, but the beacon node does not use--http-mev-relay, then a warning will be displayed. This also works when failing over to a node without--http-mev-relay.Which issues(s) does this PR fix?
Fixes #11181