-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator Registration- proposer settings renaming #11057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
changed the title
fixing ux on propertynaming, introducing placeholder property
Validator Registration- proposer settings renaming
Jul 14, 2022
EnableValidatorRegistrationFlag = &cli.BoolFlag{ | ||
Name: "enable-validator-registration", | ||
Usage: "Enables validator registration APIs (MEV Builder APIs) for the validator client to update settings such as fee recipient and gas limit", | ||
// EnableBuilderFlag enables the periodic validator registration API calls that will update the custom builder with validator settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this is a breaking change so we'll need to give @Taranpreet26311 and wonderful develop team a heads up
terencechain
approved these changes
Jul 19, 2022
james-prysm
added
Builder
PR or issue that supports builder related work
Breaking Change
labels
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
related to #Consensys/teku#5860
What does this PR do? Why is it needed?
validator_registration
field in proposer settings tobuilder
enable-validator-registration
toenable-builder
enable
field n proposer settings toenabled
relays
fieldvalidator: will not be included in validator registration until a validator index is assigned
#11061)fixes #11061