Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator Registration- proposer settings renaming #11057

Merged
merged 13 commits into from
Jul 19, 2022

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Jul 14, 2022

What type of PR is this?

Feature

related to #Consensys/teku#5860

What does this PR do? Why is it needed?

fixes #11061

@james-prysm james-prysm requested a review from a team as a code owner July 14, 2022 21:31
@james-prysm james-prysm marked this pull request as draft July 14, 2022 21:33
@james-prysm james-prysm changed the title fixing ux on propertynaming, introducing placeholder property Validator Registration- proposer settings renaming Jul 14, 2022
@james-prysm james-prysm marked this pull request as ready for review July 15, 2022 15:36
@james-prysm james-prysm self-assigned this Jul 15, 2022
EnableValidatorRegistrationFlag = &cli.BoolFlag{
Name: "enable-validator-registration",
Usage: "Enables validator registration APIs (MEV Builder APIs) for the validator client to update settings such as fee recipient and gas limit",
// EnableBuilderFlag enables the periodic validator registration API calls that will update the custom builder with validator settings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is a breaking change so we'll need to give @Taranpreet26311 and wonderful develop team a heads up

validator/client/validator.go Outdated Show resolved Hide resolved
@james-prysm james-prysm requested a review from terencechain July 18, 2022 14:56
@james-prysm james-prysm merged commit 30b8fba into develop Jul 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the validator-registration-cli-changes branch July 19, 2022 13:38
@james-prysm james-prysm added Builder PR or issue that supports builder related work Breaking Change labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builder PR or issue that supports builder related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validator: will not be included in validator registration until a validator index is assigned
2 participants